fix: name unhinted type vars without panicking#239
Merged
Conversation
Merged
Owner
Author
|
Released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LSP crashed with
type var index is valid hex digitwhen a hover or completion had to display a type with seven or more unhinted type variables. The fallback name generator relied onchar::from_digit(_, 16), which runs out of digits at index 6.Generated names now follow
A, B, …, Z, AA, AB, …(bijective base-26 over A-Z), so in practice arbitrarily many fresh type variables render without panicking.Fix #236