fix: security audit — shell injection, temp files, license, Dockerfile#49
Merged
fix: security audit — shell injection, temp files, license, Dockerfile#49
Conversation
- Replace all execSync template literals with execFileSync array args in docker.ts and upgrade.ts to prevent shell injection - Use mktemp/mkdtempSync for temp files instead of predictable /tmp paths - Fix license in homebrew formula: MIT -> Apache-2.0 (matches LICENSE file) - Add non-root USER to Dockerfile - Add SECURITY.md documenting ArangoDB auth, install risks, and reporting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security hardening based on full repo audit.
Changes
execSynctemplate literals withexecFileSyncarray args indocker.tsandupgrade.tsmktemp/mkdtempSyncinstead of predictable/tmppaths ininstall.shandupgrade.tsApache-2.0Test plan
ix docker start/ix docker stopstill workix upgrade --checkworkscurl ... | bashinstall still works