⚡ Bolt: Optimize readFileSync to reduce buffer allocations

.jules/bolt.md

@@ -0,0 +1,3 @@
+## 2024-11-20 - Optimize readFileSync by removing intermediate buffer allocations
+**Learning:** Calling `.toString()` on the buffer returned by `fs.readFileSync` allocates unnecessary memory for the intermediate Buffer object.
+**Action:** Always pass the encoding, such as `utf8`, directly to `fs.readFileSync(filepath, "utf8")` when the goal is to read the file contents as a string.

packages/expo-brownfield/plugin/src/common/filesystem.ts

@@ -26,13 +26,14 @@ const maybeReadOverwrittenTemplate = (template: string, platform?: PlatformStrin
   try {
     accessSync(path.join(process.cwd(), '.brownfield-templates'));
     if (existsSync(path.join(process.cwd(), '.brownfield-templates', template))) {
-      return readFileSync(path.join(process.cwd(), '.brownfield-templates', template)).toString();
+      return readFileSync(path.join(process.cwd(), '.brownfield-templates', template), 'utf8');
     }
 
     if (existsSync(path.join(process.cwd(), '.brownfield-templates', platform ?? '.', template))) {
       return readFileSync(
-        path.join(process.cwd(), '.brownfield-templates', platform ?? '.', template)
-      ).toString();
+        path.join(process.cwd(), '.brownfield-templates', platform ?? '.', template),
+        'utf8'
+      );
     }
     // eslint-disable-next-line no-empty
   } catch {}
@@ -55,7 +56,7 @@ const readTemplate = (template: string, platform?: PlatformString): string => {
     throw new Error(`Template ${template} doesn't exist at ${templatePath}`);
   }
 
-  return readFileSync(templatePath).toString();
+  return readFileSync(templatePath, 'utf8');
 };
 
 const createFileFromTemplateInternal = (

packages/pod-install/src/index.ts

@@ -41,7 +41,7 @@ async function runAsync(maybeProjectDirectory?: string): Promise<void> {
       process.exit(1);
     }
 
-    const jsonData = JSON.parse(readFileSync(packageJsonPath).toString());
+    const jsonData = JSON.parse(readFileSync(packageJsonPath, 'utf8'));
     const hasExpoPackage = jsonData.dependencies?.hasOwnProperty('expo');
 
     if (hasExpoPackage) {