Add missing Foundation import to libPhoneNumber.h #435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@mbernson - How are you consuming this library? SPM? Cocoapods? Is the issue with FOUNDATION_EXPORT not being defined coming from building this library, or building your application/component? What version of Xcode are you building with? I'm just not seeing this problem...so curious how to recreate and why I'm not seeing it... |
|
Same problem here. |
Collaborator
Contributor
Author
LowAmmo
approved these changes
Dec 1, 2025
ashoemakeora
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, the import statement at the top of
libPhoneNumber.hwas removed. This causes the build to fail because theFOUNDATION_EXPORTmacro is undefined.This PR adds an import for
#import <Foundation/Foundation.h>to fix it.