feat(shot-scraper): intégrer shot-scraper CLI comme standard navigateur ulk#141
feat(shot-scraper): intégrer shot-scraper CLI comme standard navigateur ulk#141
Conversation
…ur ulk - Ajoute `_shared/shot-scraper-protocol.md` (protocole partagé CLI) - Met à jour les 4 agents concernés (02, 17, 32, 03) : `extends: shot-scraper-protocol` - Ajoute shot-scraper à `cli-registry.json` (priority: required, replaces_mcp: chrome-devtools-mcp) - Documente dans `install-reference.md` (section CLIs requises) - Met à jour `CLAUDE.md` et `.claude/rules/frontend-agents.md` - Régénère `registry.json` / `registry.md` (87 agents) Remplace mcp__chrome-devtools__* pour visual-auditor (03), frontend-qa (02), seo-auditor (32) et agamotto (17). Source : simonw/shot-scraper (MIT). https://claude.ai/code/session_017e5NQNe53RbzGuV5Cwq5ug
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (15)
📝 WalkthroughWalkthroughThis PR introduces shot-scraper CLI as a replacement for Chrome DevTools MCP across agent configurations, including new protocol documentation, registry entries, installer support, and individual agent migrations. The build infrastructure is updated to compile the ulk binary in CI and route install.sh commands to the compiled binary. ChangesShot-Scraper Tool Introduction & Agent Migration
Build Infrastructure & Installation Flow
Estimated code review effort🎯 4 (Complex) | ⏱️ ~70 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.1)level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies" Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ot-scraper) - catalog.go : ExternalModule shot-scraper (dep: pip3, flag: --with-shot-scraper) - cli-registry.json : champs macos/linux pour compatibilité BundleModule Go struct - modules_test.go : 43 → 44 modules + shot-scraper dans disabled-by-default https://claude.ai/code/session_017e5NQNe53RbzGuV5Cwq5ug
…tructurel - test.yml: ajouter setup-go + build binaire avant bats dans test-shell - install.sh: router --check/--verify (et variantes sans --) vers ulk check/verify au lieu de ulk install (flags inexistants) - modules_test.go: remplacer TestAllHas44Modules (hardcodé) par TestAllModulesWellFormed (structurel — vérifie key/flag non-vides) Fixes: test 1 (--help exit 0), test 5 (--check affiche outils), test 7 (--verify pass/fail) https://claude.ai/code/session_017e5NQNe53RbzGuV5Cwq5ug
…amework/cli go build doit s'exécuter depuis le répertoire du module Go (framework/cli), pas depuis la racine du dépôt (pas de go.mod à la racine). https://claude.ai/code/session_017e5NQNe53RbzGuV5Cwq5ug
Summary
framework/agents/_shared/shot-scraper-protocol.md— protocole partagé CLI avec correspondances Chrome DevTools MCP, commandes clés (screenshot, JS, accessibility, multi, auth), limitations, et règle de migration agentsextends: _shared/shot-scraper-protocol.md: visual-auditor (03), frontend-qa (02), seo-auditor (32), agamotto (17)cli-registry.jsonavecpriority: requiredetreplaces_mcp: chrome-devtools-mcp.claude/rules/install-reference.md(section CLIs requises) et met à jour la description Visual Auditor dansfrontend-agents.mdregistry.json/registry.md(87 agents)Détails
shot-scraper(simonw, MIT) remplacemcp__chrome-devtools__*pour toutes les captures web dans ulk depuis 2026-05-06. Avantages : CLI stateless, zéro config MCP, fonctionne en CI/headless, Playwright intégré.Test plan
shot-scraper --versionaprèspip install shot-scraper && shot-scraper installshot-scraper <url> -o out.pngsur une URL publiqueshot-scraper-protocol.mddans leur frontmatterextends:cli-registry.jsoncontient l'entréeshot-scraperavecpriority: requiredhttps://claude.ai/code/session_017e5NQNe53RbzGuV5Cwq5ug
Generated by Claude Code
Summary by CodeRabbit
New Features
Documentation
Chores