Skip to content

Remove redundant show-verbose-logs empty-string guard#112

Merged
j178 merged 2 commits intoj178:mainfrom
shaanmajid:style/remove-verbose-logs-guard
Mar 19, 2026
Merged

Remove redundant show-verbose-logs empty-string guard#112
j178 merged 2 commits intoj178:mainfrom
shaanmajid:style/remove-verbose-logs-guard

Conversation

@shaanmajid
Copy link
Copy Markdown
Collaborator

@shaanmajid shaanmajid commented Mar 18, 2026

The action.yaml defaults "true" for show-verbose-logs, so the Actions runtime always provides a value; it is impossible forshowVerboseLogsInput to be an empty string. The === '' ? true : guard was dead code; getBooleanInput alone is sufficient.

Test mock defaults updated to reflect the runtime behavior (since action.yaml defaults are resolved before getInput is called).

@j178 j178 merged commit dc795aa into j178:main Mar 19, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants