-
-
Notifications
You must be signed in to change notification settings - Fork 127
Migrate from uv-once-map to mea OnceMap #1433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: tison <wander4096@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1433 +/- ##
==========================================
+ Coverage 90.71% 90.74% +0.03%
==========================================
Files 82 82
Lines 16783 16776 -7
==========================================
Hits 15224 15224
+ Misses 1559 1552 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
📦 Cargo Bloat ComparisonBinary size change: +0.00% (22.5 MiB → 22.5 MiB) Expand for cargo-bloat outputHead Branch ResultsBase Branch Results |
|
Thank you! |
| PYTHON_INFO_CACHE | ||
| .try_compute(python.clone(), async move || { | ||
| let info = query_python_info(&python).await?; | ||
| Ok(Arc::new(info)) | ||
| }) | ||
| .await |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semantic changes a bit. Previously, a failed call would fail all the following calls. I implement try_compute so that a failed call wouldn't set the value in the hashmap. Hopefully this is what expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine, I think the new behavior makes more sense.
No description provided.