Add `prek run --no-fail-fast` to override config file by j178 · Pull Request #1859 · j178/prek

j178 · 2026-03-24T09:37:24Z

No description provided.

codecov · 2026-03-24T09:42:07Z

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.14%. Comparing base (e9307d9) to head (19ac7cf).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
crates/prek/src/cli/mod.rs	85.71%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1859      +/-   ##
==========================================
- Coverage   92.17%   92.14%   -0.03%     
==========================================
  Files         108      108              
  Lines       21750    21757       +7     
==========================================
  Hits        20047    20047              
- Misses       1703     1710       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

Adds support for overriding config-level fail_fast behavior from the CLI by introducing a --no-fail-fast flag and plumbing a tri-state fail_fast value through the run pipeline.

Changes:

Add hidden --no-fail-fast flag and a shared flag(yes, no) -> Option<bool> resolver to represent “unset/true/false”.
Update cli::run / hook running logic to accept Option<bool> and let CLI override config values.
Add an integration test asserting --no-fail-fast overrides fail_fast: true in config.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
crates/prek/src/cli/mod.rs	Adds `--no-fail-fast` and a helper to resolve paired boolean flags to `Option<bool>`.
crates/prek/src/cli/run/run.rs	Switches `fail_fast` plumbing to `Option<bool>` and updates config/CLI precedence logic.
crates/prek/src/main.rs	Wires `RunArgs` into `cli::run` using the new flag resolver.
crates/prek/src/cli/try_repo.rs	Passes resolved `fail_fast` option through to `cli::run` for `try-repo`.
crates/prek/src/cli/hook_impl.rs	Passes resolved `fail_fast` option through to `cli::run` for hook shims.
crates/prek/tests/run.rs	Adds a test to validate `--no-fail-fast` overrides config-level `fail_fast`.

crates/prek/src/cli/mod.rs

prek-ci-bot · 2026-03-24T09:48:15Z

📦 Cargo Bloat Comparison

Binary size change: +0.00% (25.4 MiB → 25.4 MiB)

Expand for cargo-bloat output

Head Branch Results

 File  .text     Size             Crate Name
 1.3%   2.7% 332.0KiB        aws_lc_sys aws_lc_0_39_0_aes_gcm_encrypt_avx512
 1.3%   2.7% 332.0KiB        aws_lc_sys aws_lc_0_39_0_aes_gcm_decrypt_avx512
 0.3%   0.7%  82.5KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  75.8KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  69.0KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.5%  56.8KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.4%  51.0KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.4%  47.4KiB              prek prek::run::{{closure}}
 0.2%   0.3%  42.3KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.3%  33.3KiB             prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_39_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.8KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_39_0_edwards25519_scalarmuldouble
 0.1%   0.2%  26.8KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  26.6KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  24.2KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  23.0KiB              prek prek::hooks::meta_hooks::MetaHooks::run::{{closure}}
 0.1%   0.2%  22.4KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
 0.1%   0.2%  21.7KiB              prek prek::workspace::Project::init_hooks::{{closure}}
41.5%  86.2%  10.5MiB                   And 23869 smaller methods. Use -n N to show more.
48.2% 100.0%  12.2MiB                   .text section size, the file size is 25.4MiB

Base Branch Results

 File  .text     Size             Crate Name
 1.3%   2.7% 332.0KiB        aws_lc_sys aws_lc_0_39_0_aes_gcm_encrypt_avx512
 1.3%   2.7% 332.0KiB        aws_lc_sys aws_lc_0_39_0_aes_gcm_decrypt_avx512
 0.3%   0.7%  82.5KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  75.8KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  71.2KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.5%  56.8KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.4%  51.0KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.4%  46.0KiB              prek prek::run::{{closure}}
 0.2%   0.3%  42.2KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.3%  32.0KiB             prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_39_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.8KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_39_0_edwards25519_scalarmuldouble
 0.1%   0.2%  26.6KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  26.3KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  24.2KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  23.0KiB              prek prek::hooks::meta_hooks::MetaHooks::run::{{closure}}
 0.1%   0.2%  22.4KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
 0.1%   0.2%  21.7KiB              prek prek::workspace::Project::init_hooks::{{closure}}
41.5%  86.2%  10.5MiB                   And 23906 smaller methods. Use -n N to show more.
48.2% 100.0%  12.2MiB                   .text section size, the file size is 25.4MiB

prek-ci-bot · 2026-03-24T09:48:15Z

⚡️ Hyperfine Benchmarks

Summary: 0 regressions, 0 improvements above the 10% threshold.

Environment

OS: Linux 6.14.0-1017-azure
CPU: 4 cores
prek version: prek 0.3.8+4 (ce8e8ef 2026-03-24)
Rust version: rustc 1.94.0 (4a4ef493e 2026-03-02)
Hyperfine version: hyperfine 1.20.0

CLI Commands

Benchmarking basic commands in the main repo:

`prek --version`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base --version`	2.4 ± 0.1	2.2	2.5	1.02 ± 0.04
`prek-head --version`	2.3 ± 0.0	2.2	2.5	1.00

`prek list`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base list`	8.9 ± 0.1	8.8	9.1	1.00 ± 0.03
`prek-head list`	8.9 ± 0.2	8.7	10.7	1.00

`prek validate-config .pre-commit-config.yaml`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base validate-config .pre-commit-config.yaml`	3.2 ± 0.0	3.1	3.3	1.00
`prek-head validate-config .pre-commit-config.yaml`	3.2 ± 0.1	3.1	3.8	1.01 ± 0.04

`prek sample-config`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base sample-config`	2.6 ± 0.1	2.6	3.0	1.00
`prek-head sample-config`	2.6 ± 0.0	2.5	2.7	1.00 ± 0.03

Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

`prek run --all-files (cold - no cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	154.8 ± 2.1	151.6	159.8	1.00 ± 0.02
`prek-head run --all-files`	154.2 ± 2.4	151.5	158.9	1.00

`prek run --all-files (warm - with cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	155.4 ± 1.9	150.5	158.8	1.00
`prek-head run --all-files`	156.2 ± 3.3	152.1	165.2	1.00 ± 0.02

Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

`prek run --all-files (full builtin hook suite)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	154.6 ± 2.7	149.8	161.6	1.00
`prek-head run --all-files`	159.2 ± 28.8	149.8	357.6	1.03 ± 0.19

Individual Hook Performance

Benchmarking each hook individually on the test repo:

`prek run trailing-whitespace --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run trailing-whitespace --all-files`	21.5 ± 0.3	20.9	21.9	1.00
`prek-head run trailing-whitespace --all-files`	21.8 ± 0.5	21.1	23.5	1.01 ± 0.03

`prek run end-of-file-fixer --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run end-of-file-fixer --all-files`	27.9 ± 1.7	25.3	31.7	1.00 ± 0.10
`prek-head run end-of-file-fixer --all-files`	27.9 ± 2.0	25.4	33.5	1.00

`prek run check-json --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-json --all-files`	13.0 ± 0.2	12.6	13.5	1.02 ± 0.04
`prek-head run check-json --all-files`	12.7 ± 0.4	11.8	13.4	1.00

`prek run check-yaml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-yaml --all-files`	11.8 ± 0.3	11.5	12.9	1.01 ± 0.03
`prek-head run check-yaml --all-files`	11.7 ± 0.2	11.5	12.4	1.00

`prek run check-toml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-toml --all-files`	12.1 ± 0.3	11.6	12.8	1.02 ± 0.03
`prek-head run check-toml --all-files`	11.9 ± 0.3	11.4	12.4	1.00

`prek run check-xml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-xml --all-files`	12.1 ± 0.3	11.7	12.6	1.01 ± 0.04
`prek-head run check-xml --all-files`	12.0 ± 0.3	11.4	12.8	1.00

`prek run detect-private-key --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run detect-private-key --all-files`	18.3 ± 1.2	16.4	21.5	1.00
`prek-head run detect-private-key --all-files`	18.7 ± 1.1	16.6	21.4	1.02 ± 0.09

`prek run fix-byte-order-marker --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run fix-byte-order-marker --all-files`	24.0 ± 1.0	21.5	25.7	1.02 ± 0.08
`prek-head run fix-byte-order-marker --all-files`	23.5 ± 1.4	21.0	27.7	1.00

Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

`prek install-hooks (cold - no cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base install-hooks`	4.9 ± 0.1	4.8	5.1	1.02 ± 0.03
`prek-head install-hooks`	4.8 ± 0.1	4.7	4.9	1.00

`prek install-hooks (warm - with cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base install-hooks`	4.8 ± 0.0	4.8	4.8	1.00
`prek-head install-hooks`	4.8 ± 0.0	4.8	4.9	1.00 ± 0.01

File Filtering/Scoping Performance

Testing different file selection modes:

`prek run (staged files only)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run`	53.1 ± 1.4	50.9	56.6	1.01 ± 0.03
`prek-head run`	52.8 ± 1.0	51.6	55.4	1.00

`prek run --files '*.json' (specific file type)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --files '*.json'`	9.1 ± 0.2	8.9	9.6	1.02 ± 0.02
`prek-head run --files '*.json'`	9.0 ± 0.1	8.8	9.2	1.00

Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

`prek run --dry-run --all-files (measures init overhead)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --dry-run --all-files`	13.8 ± 0.1	13.6	14.3	1.00
`prek-head run --dry-run --all-files`	14.0 ± 0.4	13.6	15.4	1.01 ± 0.03

Meta Hooks Performance

Benchmarking meta hooks separately:

`prek run check-hooks-apply --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-hooks-apply --all-files`	14.1 ± 0.1	14.0	14.3	1.00
`prek-head run check-hooks-apply --all-files`	14.1 ± 0.2	13.9	14.5	1.00 ± 0.01

`prek run check-useless-excludes --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-useless-excludes --all-files`	13.3 ± 0.7	12.4	14.1	1.07 ± 0.06
`prek-head run check-useless-excludes --all-files`	12.5 ± 0.1	12.3	12.6	1.00

`prek run identity --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run identity --all-files`	11.0 ± 0.1	10.8	11.3	1.00 ± 0.02
`prek-head run identity --all-files`	11.0 ± 0.1	10.8	11.2	1.00

j178 added the enhancement New feature or request label Mar 24, 2026

Copilot AI review requested due to automatic review settings March 24, 2026 09:37

Copilot started reviewing on behalf of j178 March 24, 2026 09:38 View session

j178 force-pushed the support-no-fail-fast-cli-override branch from 135f3dc to 6369058 Compare March 24, 2026 09:38

Copilot AI reviewed Mar 24, 2026

View reviewed changes

crates/prek/src/cli/mod.rs Show resolved Hide resolved

crates/prek/src/cli/mod.rs Outdated Show resolved Hide resolved

crates/prek/src/cli/mod.rs Show resolved Hide resolved

Add prek run --no-fail-fast to override config file

19ac7cf

j178 force-pushed the support-no-fail-fast-cli-override branch from 6369058 to 19ac7cf Compare March 24, 2026 09:47

j178 merged commit bf09a45 into master Mar 24, 2026
53 checks passed

j178 deleted the support-no-fail-fast-cli-override branch March 24, 2026 09:57

BrewTestBot mentioned this pull request Apr 13, 2026

prek 0.3.9 Homebrew/homebrew-core#277348

Merged

Conversation

j178 commented Mar 24, 2026

Uh oh!

codecov bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

prek-ci-bot bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Cargo Bloat Comparison

Head Branch Results

Base Branch Results

Uh oh!

prek-ci-bot bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚡️ Hyperfine Benchmarks

prek --version

prek list

prek validate-config .pre-commit-config.yaml

prek sample-config

prek run --all-files (cold - no cache)

prek run --all-files (warm - with cache)

prek run --all-files (full builtin hook suite)

prek run trailing-whitespace --all-files

prek run end-of-file-fixer --all-files

prek run check-json --all-files

prek run check-yaml --all-files

prek run check-toml --all-files

prek run check-xml --all-files

prek run detect-private-key --all-files

prek run fix-byte-order-marker --all-files

prek install-hooks (cold - no cache)

prek install-hooks (warm - with cache)

prek run (staged files only)

prek run --files '*.json' (specific file type)

prek run --dry-run --all-files (measures init overhead)

prek run check-hooks-apply --all-files

prek run check-useless-excludes --all-files

prek run identity --all-files

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Mar 24, 2026 •

edited

Loading

prek-ci-bot bot commented Mar 24, 2026 •

edited

Loading

prek-ci-bot bot commented Mar 24, 2026 •

edited

Loading

`prek --version`

`prek list`

`prek validate-config .pre-commit-config.yaml`

`prek sample-config`

`prek run --all-files (cold - no cache)`

`prek run --all-files (warm - with cache)`

`prek run --all-files (full builtin hook suite)`

`prek run trailing-whitespace --all-files`

`prek run end-of-file-fixer --all-files`

`prek run check-json --all-files`

`prek run check-yaml --all-files`

`prek run check-toml --all-files`

`prek run check-xml --all-files`

`prek run detect-private-key --all-files`

`prek run fix-byte-order-marker --all-files`

`prek install-hooks (cold - no cache)`

`prek install-hooks (warm - with cache)`

`prek run (staged files only)`

`prek run --files '*.json' (specific file type)`

`prek run --dry-run --all-files (measures init overhead)`

`prek run check-hooks-apply --all-files`

`prek run check-useless-excludes --all-files`

`prek run identity --all-files`