Canonicalize CWD and GIT_ROOT paths by j178 · Pull Request #1878 · j178/prek

j178 · 2026-04-01T09:16:57Z

Closes #1850
Closes #1875

codecov · 2026-04-01T09:19:23Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.15%. Comparing base (0b6df1f) to head (327416c).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1878      +/-   ##
==========================================
+ Coverage   92.12%   92.15%   +0.03%     
==========================================
  Files         112      112              
  Lines       22522    22528       +6     
==========================================
+ Hits        20748    20761      +13     
+ Misses       1774     1767       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

prek-ci-bot · 2026-04-01T09:23:46Z

📦 Cargo Bloat Comparison

Binary size change: +0.00% (25.5 MiB → 25.5 MiB)

Expand for cargo-bloat output

Head Branch Results

 File  .text     Size             Crate Name
 1.3%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_39_0_aes_gcm_encrypt_avx512
 1.3%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_39_0_aes_gcm_decrypt_avx512
 0.3%   0.7%  86.6KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  79.7KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  69.3KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.5%  57.0KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.4%  51.0KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.4%  47.8KiB              prek prek::run::{{closure}}
 0.2%   0.3%  42.5KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.3%  33.3KiB             prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_39_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.8KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_39_0_edwards25519_scalarmuldouble
 0.1%   0.2%  26.6KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  26.6KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  25.8KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  22.8KiB              prek prek::hooks::meta_hooks::MetaHooks::run::{{closure}}
 0.1%   0.2%  22.4KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
 0.1%   0.2%  21.5KiB              prek prek::workspace::Project::init_hooks::{{closure}}
41.6%  86.2%  10.6MiB                   And 23993 smaller methods. Use -n N to show more.
48.2% 100.0%  12.3MiB                   .text section size, the file size is 25.5MiB

Base Branch Results

 File  .text     Size             Crate Name
 1.3%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_39_0_aes_gcm_encrypt_avx512
 1.3%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_39_0_aes_gcm_decrypt_avx512
 0.3%   0.7%  86.3KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  80.7KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.5%  69.1KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.5%  57.0KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.4%  51.0KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.4%  47.4KiB              prek prek::run::{{closure}}
 0.2%   0.3%  42.3KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.3%  33.3KiB             prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_39_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.8KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_39_0_edwards25519_scalarmuldouble
 0.1%   0.2%  27.1KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  26.6KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  25.8KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  22.6KiB              prek prek::hooks::meta_hooks::MetaHooks::run::{{closure}}
 0.1%   0.2%  22.4KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
 0.1%   0.2%  21.5KiB              prek prek::workspace::Project::init_hooks::{{closure}}
41.6%  86.2%  10.6MiB                   And 23964 smaller methods. Use -n N to show more.
48.2% 100.0%  12.3MiB                   .text section size, the file size is 25.5MiB

prek-ci-bot · 2026-04-01T09:23:47Z

⚡️ Hyperfine Benchmarks

Summary: 0 regressions, 0 improvements above the 10% threshold.

Environment

OS: Linux 6.17.0-1008-azure
CPU: 4 cores
prek version: prek 0.3.8+13 (1d2fadf 2026-04-01)
Rust version: rustc 1.94.1 (e408947bf 2026-03-25)
Hyperfine version: hyperfine 1.20.0

CLI Commands

Benchmarking basic commands in the main repo:

`prek --version`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base --version`	2.2 ± 0.1	2.0	2.7	1.06 ± 0.07
`prek-head --version`	2.1 ± 0.0	2.0	2.3	1.00

`prek list`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base list`	8.4 ± 0.1	8.2	8.8	1.00
`prek-head list`	8.4 ± 0.3	8.2	11.5	1.00 ± 0.04

`prek validate-config .pre-commit-config.yaml`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base validate-config .pre-commit-config.yaml`	2.9 ± 0.0	2.8	3.0	1.01 ± 0.03
`prek-head validate-config .pre-commit-config.yaml`	2.8 ± 0.1	2.7	3.0	1.00

`prek sample-config`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base sample-config`	2.4 ± 0.0	2.3	2.5	1.00
`prek-head sample-config`	2.4 ± 0.0	2.3	2.5	1.00 ± 0.02

Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

`prek run --all-files (cold - no cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	136.5 ± 3.5	132.5	142.8	1.00
`prek-head run --all-files`	139.9 ± 4.4	133.6	150.4	1.02 ± 0.04

`prek run --all-files (warm - with cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	138.7 ± 3.3	132.2	145.4	1.00
`prek-head run --all-files`	139.3 ± 3.2	133.0	144.3	1.00 ± 0.03

Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

`prek run --all-files (full builtin hook suite)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	138.8 ± 3.7	130.9	145.3	1.00
`prek-head run --all-files`	141.0 ± 4.1	132.2	148.1	1.02 ± 0.04

Individual Hook Performance

Benchmarking each hook individually on the test repo:

`prek run trailing-whitespace --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run trailing-whitespace --all-files`	20.3 ± 0.5	19.6	21.6	1.00
`prek-head run trailing-whitespace --all-files`	20.4 ± 0.5	19.7	21.4	1.01 ± 0.03

`prek run end-of-file-fixer --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run end-of-file-fixer --all-files`	28.8 ± 2.8	24.8	35.1	1.09 ± 0.14
`prek-head run end-of-file-fixer --all-files`	26.4 ± 2.3	22.7	31.3	1.00

`prek run check-json --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-json --all-files`	12.1 ± 0.3	11.5	12.6	1.05 ± 0.05
`prek-head run check-json --all-files`	11.5 ± 0.5	10.7	12.5	1.00

`prek run check-yaml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-yaml --all-files`	21.9 ± 26.5	10.7	107.7	1.96 ± 2.38
`prek-head run check-yaml --all-files`	11.2 ± 0.3	10.7	12.0	1.00

`prek run check-toml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-toml --all-files`	11.3 ± 0.4	10.7	12.1	1.01 ± 0.04
`prek-head run check-toml --all-files`	11.1 ± 0.3	10.6	11.8	1.00

`prek run check-xml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-xml --all-files`	11.4 ± 0.3	10.9	12.2	1.00 ± 0.05
`prek-head run check-xml --all-files`	11.3 ± 0.4	10.7	12.3	1.00

`prek run detect-private-key --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run detect-private-key --all-files`	17.5 ± 1.1	15.2	20.5	1.01 ± 0.10
`prek-head run detect-private-key --all-files`	17.4 ± 1.3	15.6	20.6	1.00

`prek run fix-byte-order-marker --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run fix-byte-order-marker --all-files`	22.1 ± 2.1	18.6	27.5	1.04 ± 0.15
`prek-head run fix-byte-order-marker --all-files`	21.4 ± 2.2	18.3	26.2	1.00

Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

`prek install-hooks (cold - no cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base install-hooks`	4.3 ± 0.1	4.2	4.3	1.00
`prek-head install-hooks`	4.3 ± 0.1	4.2	4.4	1.01 ± 0.02

`prek install-hooks (warm - with cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base install-hooks`	4.3 ± 0.1	4.2	4.3	1.00
`prek-head install-hooks`	4.4 ± 0.1	4.3	4.5	1.02 ± 0.03

File Filtering/Scoping Performance

Testing different file selection modes:

`prek run (staged files only)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run`	47.9 ± 1.1	46.1	49.8	1.00
`prek-head run`	48.4 ± 1.0	46.8	50.3	1.01 ± 0.03

`prek run --files '*.json' (specific file type)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --files '*.json'`	8.2 ± 0.2	8.0	8.7	1.00
`prek-head run --files '*.json'`	8.2 ± 0.4	7.9	9.8	1.00 ± 0.06

Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

`prek run --dry-run --all-files (measures init overhead)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --dry-run --all-files`	12.5 ± 0.2	12.2	13.3	1.00
`prek-head run --dry-run --all-files`	12.8 ± 1.5	12.3	19.1	1.02 ± 0.12

Meta Hooks Performance

Benchmarking meta hooks separately:

`prek run check-hooks-apply --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-hooks-apply --all-files`	11.5 ± 0.4	11.2	12.6	1.00
`prek-head run check-hooks-apply --all-files`	11.6 ± 0.4	11.3	13.0	1.00 ± 0.05

`prek run check-useless-excludes --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-useless-excludes --all-files`	11.3 ± 0.1	11.2	11.6	1.00 ± 0.01
`prek-head run check-useless-excludes --all-files`	11.3 ± 0.1	11.2	11.6	1.00

`prek run identity --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run identity --all-files`	9.9 ± 0.1	9.7	10.1	1.00
`prek-head run identity --all-files`	10.2 ± 0.3	9.9	11.1	1.03 ± 0.03

Copilot

Pull request overview

This PR addresses Windows path-equivalence edge cases by canonicalizing process paths used for workspace/git-root comparisons, reducing failures caused by mismatched casing or drive mappings.

Changes:

Canonicalize GIT_ROOT when discovered from git rev-parse --show-toplevel.
Canonicalize the global CWD when captured from std::env::current_dir().

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
crates/prek/src/git.rs	Canonicalizes `GIT_ROOT` before it’s used for prefix/strip checks against workspace paths.
crates/prek/src/fs.rs	Canonicalizes the global `CWD` so workspace discovery and related path logic starts from a canonical path.

crates/prek/src/fs.rs

crates/prek/src/git.rs

crates/prek/src/fs.rs

Canonicalize CWD and GIT_ROOT paths

327416c

j178 added the bug Something isn't working label Apr 1, 2026

j178 marked this pull request as ready for review April 1, 2026 09:23

Copilot AI review requested due to automatic review settings April 1, 2026 09:23

Copilot started reviewing on behalf of j178 April 1, 2026 09:24 View session

Copilot AI reviewed Apr 1, 2026

View reviewed changes

crates/prek/src/fs.rs Show resolved Hide resolved

crates/prek/src/fs.rs Show resolved Hide resolved

crates/prek/src/git.rs Show resolved Hide resolved

crates/prek/src/fs.rs Show resolved Hide resolved

j178 merged commit dd2ab40 into master Apr 1, 2026
60 checks passed

j178 deleted the resolve branch April 1, 2026 09:31

BrewTestBot mentioned this pull request Apr 13, 2026

prek 0.3.9 Homebrew/homebrew-core#277348

Merged

Conversation

j178 commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

prek-ci-bot bot commented Apr 1, 2026

📦 Cargo Bloat Comparison

Head Branch Results

Base Branch Results

Uh oh!

prek-ci-bot bot commented Apr 1, 2026

⚡️ Hyperfine Benchmarks

prek --version

prek list

prek validate-config .pre-commit-config.yaml

prek sample-config

prek run --all-files (cold - no cache)

prek run --all-files (warm - with cache)

prek run --all-files (full builtin hook suite)

prek run trailing-whitespace --all-files

prek run end-of-file-fixer --all-files

prek run check-json --all-files

prek run check-yaml --all-files

prek run check-toml --all-files

prek run check-xml --all-files

prek run detect-private-key --all-files

prek run fix-byte-order-marker --all-files

prek install-hooks (cold - no cache)

prek install-hooks (warm - with cache)

prek run (staged files only)

prek run --files '*.json' (specific file type)

prek run --dry-run --all-files (measures init overhead)

prek run check-hooks-apply --all-files

prek run check-useless-excludes --all-files

prek run identity --all-files

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

j178 commented Apr 1, 2026 •

edited

Loading

codecov bot commented Apr 1, 2026 •

edited

Loading

`prek --version`

`prek list`

`prek validate-config .pre-commit-config.yaml`

`prek sample-config`

`prek run --all-files (cold - no cache)`

`prek run --all-files (warm - with cache)`

`prek run --all-files (full builtin hook suite)`

`prek run trailing-whitespace --all-files`

`prek run end-of-file-fixer --all-files`

`prek run check-json --all-files`

`prek run check-yaml --all-files`

`prek run check-toml --all-files`

`prek run check-xml --all-files`

`prek run detect-private-key --all-files`

`prek run fix-byte-order-marker --all-files`

`prek install-hooks (cold - no cache)`

`prek install-hooks (warm - with cache)`

`prek run (staged files only)`

`prek run --files '*.json' (specific file type)`

`prek run --dry-run --all-files (measures init overhead)`

`prek run check-hooks-apply --all-files`

`prek run check-useless-excludes --all-files`

`prek run identity --all-files`