Display auto-update results by config entry#1922
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1922 +/- ##
==========================================
+ Coverage 92.08% 92.13% +0.04%
==========================================
Files 112 112
Lines 22936 23067 +131
==========================================
+ Hits 21120 21252 +132
+ Misses 1816 1815 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1f9f6d341
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Updates auto-update output formatting to report results grouped by config entry (project config file → repo), including per-entry details like rev line numbers and clearer “frozen comment” messaging.
Changes:
- Reworks
auto-updatedisplay logic to emit structured events and render grouped, stable output (including per-entry line numbers where needed). - Adjusts frozen-comment mismatch handling/output wording (e.g., “frozen comment” vs “frozen reference”).
- Updates integration test snapshots to match the new stdout/stderr format.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/prek/src/cli/auto_update.rs | Introduces event-based rendering for auto-update results and updates frozen-comment mismatch naming/behavior. |
| crates/prek/tests/auto_update.rs | Updates snapshots to reflect the new grouped auto-update output format. |
📦 Cargo Bloat ComparisonBinary size change: +0.00% (25.7 MiB → 25.7 MiB) Expand for cargo-bloat outputHead Branch ResultsBase Branch Results |
⚡️ Hyperfine BenchmarksSummary: 0 regressions, 0 improvements above the 10% threshold. Environment
CLI CommandsBenchmarking basic commands in the main repo:
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base --version |
1.7 ± 0.1 | 1.6 | 1.9 | 1.01 ± 0.05 |
prek-head --version |
1.7 ± 0.1 | 1.6 | 1.8 | 1.00 |
prek list
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base list |
7.5 ± 0.2 | 7.1 | 8.0 | 1.00 |
prek-head list |
7.7 ± 2.6 | 7.2 | 33.3 | 1.03 ± 0.35 |
prek validate-config .pre-commit-config.yaml
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base validate-config .pre-commit-config.yaml |
2.6 ± 0.1 | 2.4 | 2.9 | 1.04 ± 0.05 |
prek-head validate-config .pre-commit-config.yaml |
2.5 ± 0.1 | 2.4 | 2.9 | 1.00 |
prek sample-config
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base sample-config |
2.0 ± 0.1 | 1.9 | 2.1 | 1.02 ± 0.04 |
prek-head sample-config |
2.0 ± 0.1 | 1.8 | 2.1 | 1.00 |
Cold vs Warm Runs
Comparing first run (cold) vs subsequent runs (warm cache):
prek run --all-files (cold - no cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
105.8 ± 11.2 | 94.4 | 130.2 | 1.07 ± 0.11 |
prek-head run --all-files |
98.8 ± 1.5 | 97.1 | 101.6 | 1.00 |
prek run --all-files (warm - with cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
99.1 ± 2.0 | 94.2 | 102.7 | 1.01 ± 0.03 |
prek-head run --all-files |
98.4 ± 2.2 | 93.6 | 101.6 | 1.00 |
Full Hook Suite
Running the builtin hook suite on the benchmark workspace:
prek run --all-files (full builtin hook suite)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
97.8 ± 2.0 | 93.1 | 101.8 | 1.01 ± 0.03 |
prek-head run --all-files |
97.3 ± 1.8 | 93.3 | 100.7 | 1.00 |
Individual Hook Performance
Benchmarking each hook individually on the test repo:
prek run trailing-whitespace --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run trailing-whitespace --all-files |
14.4 ± 0.3 | 13.8 | 15.1 | 1.02 ± 0.03 |
prek-head run trailing-whitespace --all-files |
14.2 ± 0.3 | 13.5 | 14.7 | 1.00 |
prek run end-of-file-fixer --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run end-of-file-fixer --all-files |
18.9 ± 1.2 | 16.7 | 21.4 | 1.00 |
prek-head run end-of-file-fixer --all-files |
19.2 ± 1.2 | 17.1 | 21.9 | 1.02 ± 0.09 |
prek run check-json --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-json --all-files |
8.6 ± 0.2 | 8.2 | 8.9 | 1.00 |
prek-head run check-json --all-files |
8.6 ± 0.2 | 8.1 | 9.0 | 1.01 ± 0.03 |
prek run check-yaml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-yaml --all-files |
8.2 ± 0.2 | 7.9 | 8.8 | 1.02 ± 0.03 |
prek-head run check-yaml --all-files |
8.0 ± 0.2 | 7.8 | 8.4 | 1.00 |
prek run check-toml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-toml --all-files |
8.3 ± 0.2 | 7.8 | 8.5 | 1.02 ± 0.04 |
prek-head run check-toml --all-files |
8.1 ± 0.2 | 7.8 | 8.5 | 1.00 |
prek run check-xml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-xml --all-files |
8.2 ± 0.1 | 8.0 | 8.5 | 1.00 |
prek-head run check-xml --all-files |
8.2 ± 0.2 | 7.8 | 8.8 | 1.00 ± 0.03 |
prek run detect-private-key --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run detect-private-key --all-files |
13.0 ± 0.9 | 11.8 | 14.8 | 1.03 ± 0.09 |
prek-head run detect-private-key --all-files |
12.7 ± 0.7 | 11.7 | 14.6 | 1.00 |
prek run fix-byte-order-marker --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run fix-byte-order-marker --all-files |
16.5 ± 1.0 | 14.9 | 18.6 | 1.04 ± 0.09 |
prek-head run fix-byte-order-marker --all-files |
15.9 ± 0.9 | 14.6 | 18.2 | 1.00 |
Installation Performance
Benchmarking hook installation (fast path hooks skip Python setup):
prek install-hooks (cold - no cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base install-hooks |
3.6 ± 0.1 | 3.5 | 3.7 | 1.03 ± 0.05 |
prek-head install-hooks |
3.5 ± 0.2 | 3.4 | 3.7 | 1.00 |
prek install-hooks (warm - with cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base install-hooks |
3.5 ± 0.0 | 3.5 | 3.6 | 1.00 ± 0.03 |
prek-head install-hooks |
3.5 ± 0.1 | 3.4 | 3.6 | 1.00 |
File Filtering/Scoping Performance
Testing different file selection modes:
prek run (staged files only)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run |
34.1 ± 0.5 | 33.1 | 35.1 | 1.00 ± 0.02 |
prek-head run |
34.1 ± 0.6 | 33.1 | 35.4 | 1.00 |
prek run --files '*.json' (specific file type)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --files '*.json' |
6.1 ± 0.1 | 5.9 | 6.3 | 1.01 ± 0.02 |
prek-head run --files '*.json' |
6.1 ± 0.1 | 5.9 | 6.3 | 1.00 |
Workspace Discovery & Initialization
Benchmarking hook discovery and initialization overhead:
prek run --dry-run --all-files (measures init overhead)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --dry-run --all-files |
9.2 ± 0.1 | 9.0 | 9.4 | 1.00 |
prek-head run --dry-run --all-files |
26.1 ± 35.5 | 9.1 | 112.8 | 2.83 ± 3.86 |
Meta Hooks Performance
Benchmarking meta hooks separately:
prek run check-hooks-apply --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-hooks-apply --all-files |
9.4 ± 0.1 | 9.3 | 9.6 | 1.00 |
prek-head run check-hooks-apply --all-files |
9.4 ± 0.1 | 9.2 | 9.6 | 1.00 ± 0.02 |
prek run check-useless-excludes --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-useless-excludes --all-files |
9.4 ± 0.1 | 9.2 | 9.5 | 1.02 ± 0.01 |
prek-head run check-useless-excludes --all-files |
9.2 ± 0.1 | 9.0 | 9.4 | 1.00 |
prek run identity --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run identity --all-files |
8.0 ± 0.4 | 7.5 | 8.5 | 1.07 ± 0.05 |
prek-head run identity --all-files |
7.5 ± 0.1 | 7.4 | 7.6 | 1.00 |
b1f9f6d to
2ea56d1
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2ea56d1400
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2ea56d1 to
f406f4b
Compare
No description provided.