Skip to content

Display auto-update results by config entry#1922

Merged
j178 merged 2 commits intomasterfrom
auto-update-display
Apr 12, 2026
Merged

Display auto-update results by config entry#1922
j178 merged 2 commits intomasterfrom
auto-update-display

Conversation

@j178
Copy link
Copy Markdown
Owner

@j178 j178 commented Apr 10, 2026

No description provided.

@j178 j178 added the enhancement New feature or request label Apr 10, 2026
Copilot AI review requested due to automatic review settings April 10, 2026 11:31
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

❌ Patch coverage is 95.41284% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.13%. Comparing base (7899b90) to head (744260a).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
crates/prek/src/cli/auto_update.rs 95.41% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1922      +/-   ##
==========================================
+ Coverage   92.08%   92.13%   +0.04%     
==========================================
  Files         112      112              
  Lines       22936    23067     +131     
==========================================
+ Hits        21120    21252     +132     
+ Misses       1816     1815       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b1f9f6d341

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates auto-update output formatting to report results grouped by config entry (project config file → repo), including per-entry details like rev line numbers and clearer “frozen comment” messaging.

Changes:

  • Reworks auto-update display logic to emit structured events and render grouped, stable output (including per-entry line numbers where needed).
  • Adjusts frozen-comment mismatch handling/output wording (e.g., “frozen comment” vs “frozen reference”).
  • Updates integration test snapshots to match the new stdout/stderr format.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
crates/prek/src/cli/auto_update.rs Introduces event-based rendering for auto-update results and updates frozen-comment mismatch naming/behavior.
crates/prek/tests/auto_update.rs Updates snapshots to reflect the new grouped auto-update output format.

@prek-ci-bot
Copy link
Copy Markdown

prek-ci-bot bot commented Apr 10, 2026

📦 Cargo Bloat Comparison

Binary size change: +0.00% (25.7 MiB → 25.7 MiB)

Expand for cargo-bloat output

Head Branch Results

 File  .text     Size             Crate Name
 1.3%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_39_1_aes_gcm_encrypt_avx512
 1.3%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_39_1_aes_gcm_decrypt_avx512
 0.3%   0.7%  87.6KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  82.1KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.5%  69.5KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.4%  57.0KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.4%  52.5KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.4%  45.2KiB              prek prek::run::{{closure}}
 0.2%   0.3%  41.9KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.3%  32.4KiB             prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  30.0KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  28.0KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_39_1_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_39_1_edwards25519_scalarmuldouble
 0.1%   0.2%  26.8KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  26.6KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  22.8KiB              prek prek::hooks::meta_hooks::MetaHooks::run::{{closure}}
 0.1%   0.2%  22.6KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
 0.1%   0.2%  21.5KiB      clap_builder clap_builder::parser::parser::Parser::get_matches_with
41.8%  86.3%  10.7MiB                   And 24094 smaller methods. Use -n N to show more.
48.4% 100.0%  12.4MiB                   .text section size, the file size is 25.7MiB

Base Branch Results

 File  .text     Size             Crate Name
 1.3%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_39_1_aes_gcm_encrypt_avx512
 1.3%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_39_1_aes_gcm_decrypt_avx512
 0.3%   0.7%  88.1KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.7%  84.1KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.3%   0.6%  81.3KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.2%   0.4%  57.0KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.4%  52.5KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.4%  45.3KiB              prek prek::run::{{closure}}
 0.2%   0.3%  41.9KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.3%  32.4KiB             prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  30.0KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  28.0KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_39_1_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_39_1_edwards25519_scalarmuldouble
 0.1%   0.2%  27.0KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  26.8KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  22.8KiB              prek prek::hooks::meta_hooks::MetaHooks::run::{{closure}}
 0.1%   0.2%  22.6KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
 0.1%   0.2%  21.5KiB      clap_builder clap_builder::parser::parser::Parser::get_matches_with
41.8%  86.2%  10.7MiB                   And 24053 smaller methods. Use -n N to show more.
48.5% 100.0%  12.5MiB                   .text section size, the file size is 25.7MiB

@prek-ci-bot
Copy link
Copy Markdown

prek-ci-bot bot commented Apr 10, 2026

⚡️ Hyperfine Benchmarks

Summary: 0 regressions, 0 improvements above the 10% threshold.

Environment
  • OS: Linux 6.17.0-1010-azure
  • CPU: 4 cores
  • prek version: prek 0.3.8+45 (290d9dc 2026-04-12)
  • Rust version: rustc 1.94.1 (e408947bf 2026-03-25)
  • Hyperfine version: hyperfine 1.20.0
CLI Commands

Benchmarking basic commands in the main repo:

prek --version

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base --version 1.7 ± 0.1 1.6 1.9 1.01 ± 0.05
prek-head --version 1.7 ± 0.1 1.6 1.8 1.00

prek list

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base list 7.5 ± 0.2 7.1 8.0 1.00
prek-head list 7.7 ± 2.6 7.2 33.3 1.03 ± 0.35

prek validate-config .pre-commit-config.yaml

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base validate-config .pre-commit-config.yaml 2.6 ± 0.1 2.4 2.9 1.04 ± 0.05
prek-head validate-config .pre-commit-config.yaml 2.5 ± 0.1 2.4 2.9 1.00

prek sample-config

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base sample-config 2.0 ± 0.1 1.9 2.1 1.02 ± 0.04
prek-head sample-config 2.0 ± 0.1 1.8 2.1 1.00
Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

prek run --all-files (cold - no cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 105.8 ± 11.2 94.4 130.2 1.07 ± 0.11
prek-head run --all-files 98.8 ± 1.5 97.1 101.6 1.00

prek run --all-files (warm - with cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 99.1 ± 2.0 94.2 102.7 1.01 ± 0.03
prek-head run --all-files 98.4 ± 2.2 93.6 101.6 1.00
Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

prek run --all-files (full builtin hook suite)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 97.8 ± 2.0 93.1 101.8 1.01 ± 0.03
prek-head run --all-files 97.3 ± 1.8 93.3 100.7 1.00
Individual Hook Performance

Benchmarking each hook individually on the test repo:

prek run trailing-whitespace --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run trailing-whitespace --all-files 14.4 ± 0.3 13.8 15.1 1.02 ± 0.03
prek-head run trailing-whitespace --all-files 14.2 ± 0.3 13.5 14.7 1.00

prek run end-of-file-fixer --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run end-of-file-fixer --all-files 18.9 ± 1.2 16.7 21.4 1.00
prek-head run end-of-file-fixer --all-files 19.2 ± 1.2 17.1 21.9 1.02 ± 0.09

prek run check-json --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-json --all-files 8.6 ± 0.2 8.2 8.9 1.00
prek-head run check-json --all-files 8.6 ± 0.2 8.1 9.0 1.01 ± 0.03

prek run check-yaml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-yaml --all-files 8.2 ± 0.2 7.9 8.8 1.02 ± 0.03
prek-head run check-yaml --all-files 8.0 ± 0.2 7.8 8.4 1.00

prek run check-toml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-toml --all-files 8.3 ± 0.2 7.8 8.5 1.02 ± 0.04
prek-head run check-toml --all-files 8.1 ± 0.2 7.8 8.5 1.00

prek run check-xml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-xml --all-files 8.2 ± 0.1 8.0 8.5 1.00
prek-head run check-xml --all-files 8.2 ± 0.2 7.8 8.8 1.00 ± 0.03

prek run detect-private-key --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run detect-private-key --all-files 13.0 ± 0.9 11.8 14.8 1.03 ± 0.09
prek-head run detect-private-key --all-files 12.7 ± 0.7 11.7 14.6 1.00

prek run fix-byte-order-marker --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run fix-byte-order-marker --all-files 16.5 ± 1.0 14.9 18.6 1.04 ± 0.09
prek-head run fix-byte-order-marker --all-files 15.9 ± 0.9 14.6 18.2 1.00
Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

prek install-hooks (cold - no cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base install-hooks 3.6 ± 0.1 3.5 3.7 1.03 ± 0.05
prek-head install-hooks 3.5 ± 0.2 3.4 3.7 1.00

prek install-hooks (warm - with cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base install-hooks 3.5 ± 0.0 3.5 3.6 1.00 ± 0.03
prek-head install-hooks 3.5 ± 0.1 3.4 3.6 1.00
File Filtering/Scoping Performance

Testing different file selection modes:

prek run (staged files only)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run 34.1 ± 0.5 33.1 35.1 1.00 ± 0.02
prek-head run 34.1 ± 0.6 33.1 35.4 1.00

prek run --files '*.json' (specific file type)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --files '*.json' 6.1 ± 0.1 5.9 6.3 1.01 ± 0.02
prek-head run --files '*.json' 6.1 ± 0.1 5.9 6.3 1.00
Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

prek run --dry-run --all-files (measures init overhead)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --dry-run --all-files 9.2 ± 0.1 9.0 9.4 1.00
prek-head run --dry-run --all-files 26.1 ± 35.5 9.1 112.8 2.83 ± 3.86
Meta Hooks Performance

Benchmarking meta hooks separately:

prek run check-hooks-apply --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-hooks-apply --all-files 9.4 ± 0.1 9.3 9.6 1.00
prek-head run check-hooks-apply --all-files 9.4 ± 0.1 9.2 9.6 1.00 ± 0.02

prek run check-useless-excludes --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-useless-excludes --all-files 9.4 ± 0.1 9.2 9.5 1.02 ± 0.01
prek-head run check-useless-excludes --all-files 9.2 ± 0.1 9.0 9.4 1.00

prek run identity --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run identity --all-files 8.0 ± 0.4 7.5 8.5 1.07 ± 0.05
prek-head run identity --all-files 7.5 ± 0.1 7.4 7.6 1.00

Base automatically changed from auto-update-impostor-checks to master April 11, 2026 14:50
@j178 j178 force-pushed the auto-update-display branch from b1f9f6d to 2ea56d1 Compare April 12, 2026 06:25
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2ea56d1400

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot AI review requested due to automatic review settings April 12, 2026 06:42
@j178 j178 force-pushed the auto-update-display branch from 2ea56d1 to f406f4b Compare April 12, 2026 06:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@j178 j178 merged commit 059f272 into master Apr 12, 2026
56 checks passed
@j178 j178 deleted the auto-update-display branch April 12, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants