Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1982 +/- ##
=======================================
Coverage 92.21% 92.22%
=======================================
Files 116 116
Lines 23338 23338
=======================================
+ Hits 21522 21524 +2
+ Misses 1816 1814 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the npm distribution metadata so Android/Termux (process.platform=android) installs and runs prek by selecting a dedicated Android optionalDependency package, while still reusing the existing aarch64-unknown-linux-musl artifact.
Changes:
- Split the previous combined Linux/Android arm64 musl handling into a Linux-only musl package plus a new
@j178/prek-android-arm64package. - Adjust npm platform package
package.jsongeneration to always emitlibcwhen specified (and omit it for the Android package). - Simplify libc matching in
npm/bin/prek.jsto a directspec.libccomparison.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/build-npm-packages.py | Adds a dedicated Android arm64 PlatformSpec and adjusts package.json libc emission behavior. |
| npm/bin/prek.js | Removes the Android-specific libc matcher and relies on platform-specific packages for selection. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert the shared Linux/Android musl package handling from 7f44e09.
Add a dedicated
@j178/prek-android-arm64platform spec that reuses theaarch64-unknown-linux-muslartifact without package-level libc metadata, so npm can install it on Android/Termux.Follow-up to #1977