Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2025 +/- ##
==========================================
+ Coverage 92.21% 92.23% +0.01%
==========================================
Files 117 117
Lines 23825 23825
==========================================
+ Hits 21971 21974 +3
+ Misses 1854 1851 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Line 1 in 9d9b54b
Restore a real ICO payload for favicon.ico
This commit replaces docs/assets/favicon.ico with a PNG file (it now starts with the PNG magic bytes \x89PNG instead of an ICO header), while keeping the .ico filename and MkDocs config pointing to it as an icon. In browsers or tooling that do not sniff content aggressively and rely on ICO parsing for .ico resources, the favicon can fail to load, causing a visible docs regression.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Updates prek’s documentation/site branding assets to use a PNG logo and new favicon, aligning docs and README references with the new image filenames.
Changes:
- Switch MkDocs theme logo reference from
assets/logo.webptoassets/logo.png. - Update docs landing page and README to reference
logo.pnginstead oflogo.webp. - Add new
docs/assets/logo.pngand updatedocs/assets/favicon.ico; bumpuv.lockvirtual package version to0.3.11.
Reviewed changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | Updates virtual package version to 0.3.11. |
| mkdocs.yml | Points MkDocs Material theme logo at assets/logo.png. |
| docs/index.md | Switches landing-page logo reference to /assets/logo.png (and removes fixed sizing). |
| docs/assets/logo.png | Adds the new PNG logo asset. |
| docs/assets/favicon.ico | Updates favicon asset (currently appears to be PNG content despite .ico extension). |
| README.md | Switches README header area to use logo.png (and removes the <h1> title block). |
|
|
||
| <div align="center"> | ||
| <img width="220" alt="prek" src="/assets/logo.webp" /> | ||
| <img alt="prek" src="/assets/logo.png" /> |
There was a problem hiding this comment.
The logo in the docs landing page no longer has a fixed width, so it will render at its full (likely large) pixel dimensions and may dominate the page or cause layout shifts. Consider reintroducing an explicit width (or a responsive style/class) to keep the hero/logo size consistent across viewports.
| <img alt="prek" src="/assets/logo.png" /> | |
| <img alt="prek" src="/assets/logo.png" style="width: min(320px, 100%); height: auto;" /> |
| <img alt="prek" src="https://raw.githubusercontent.com/j178/prek/master/docs/assets/logo.png" /> | ||
|
|
There was a problem hiding this comment.
The README header <h1> (project name) was removed and replaced with only an image. This reduces accessibility/semantics (screen readers/SEO) and also removes the visible project name at the top of the GitHub page. Please keep a top-level heading (text) and place the logo inside/above it as needed; also consider constraining the logo width to avoid an oversized render.
| <img alt="prek" src="https://raw.githubusercontent.com/j178/prek/master/docs/assets/logo.png" /> | |
| <img | |
| alt="prek logo" | |
| src="https://raw.githubusercontent.com/j178/prek/master/docs/assets/logo.png" | |
| width="160" | |
| /> | |
| # prek |
No description provided.