Optimize meta hook file scans by j178 · Pull Request #2106 · j178/prek

j178 · 2026-05-20T03:30:52Z

Optimize the meta hook checks so they scan project files for boolean matches instead of collecting per-hook filename lists.

The shared scan helper can now stop early once all candidates have matched.

codecov · 2026-05-20T03:32:33Z

Codecov Report

❌ Patch coverage is 90.54726% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.35%. Comparing base (7780f11) to head (2198a91).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
crates/prek/src/hooks/meta_hooks.rs	92.30%	10 Missing ⚠️
crates/prek/src/cli/hook_impl.rs	50.00%	8 Missing ⚠️
crates/prek/src/cli/run/run.rs	94.73%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2106      +/-   ##
==========================================
+ Coverage   92.33%   92.35%   +0.02%     
==========================================
  Files         120      120              
  Lines       24684    24772      +88     
==========================================
+ Hits        22792    22879      +87     
- Misses       1892     1893       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 72352fb546

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot

Pull request overview

This PR optimizes meta hook checks by switching from per-hook filename list collection to boolean “any match” scans, enabling early exit once all candidates match. It also refactors a few supporting APIs to make this scan style reusable across the run/install paths.

Changes:

Update meta hook implementations to scan project files once and stop early when all relevant hooks/options have matched.
Extend the shared project-file visitor to support early termination via ControlFlow.
Refactor language support checking (Language::supported) into a method and adjust CLI/run code to use it; minor module re-exports/import cleanups.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
crates/prek/src/languages/mod.rs	Refactors `Language::supported` into a `self` method used by callers.
crates/prek/src/hooks/meta_hooks.rs	Reworks meta hook scans to avoid allocating filename lists and to break early when done.
crates/prek/src/config.rs	Removes `HookType::num_args` from config (logic moved to CLI hook impl).
crates/prek/src/cli/run/run.rs	Uses early-break scanning when deciding which missing env hooks need installation; switches to `language.supported()`.
crates/prek/src/cli/run/mod.rs	Re-exports additional filter types; makes `install` module private while exposing `InstallCache`.
crates/prek/src/cli/run/filter.rs	Adds `ControlFlow`-based early-break visitor and exposes tag filtering helpers; removes `by_type`.
crates/prek/src/cli/install.rs	Updates `InstallCache` import to new re-export location.
crates/prek/src/cli/hook_impl.rs	Moves hook arg-count validation logic into this module via `hook_num_args`.
crates/prek/src/cli/cache_gc.rs	Updates `InstallCache` import to new re-export location.

Comments suppressed due to low confidence (1)

crates/prek/src/cli/run/filter.rs:396

collect_files_from_args takes 8 parameters; removing the #[allow(clippy::too_many_arguments)] will likely make cargo clippy -D warnings fail. Either reintroduce the allow attribute or refactor the parameters into an options struct to keep clippy clean.

/// Collect files to run hooks on.
/// Returns a list of file paths relative to the git root.
async fn collect_files_from_args(
    git_root: &Path,
    workspace_root: &Path,
    hook_stage: Stage,
    from_ref: Option<String>,
    to_ref: Option<String>,
    all_files: bool,
    files: Vec<String>,
    directories: Vec<String>,
) -> Result<Vec<PathBuf>> {

prek-ci-bot · 2026-05-20T03:37:38Z

📦 Cargo Bloat Comparison

Binary size change: +0.00% (26.1 MiB → 26.1 MiB)

Expand for cargo-bloat output

Head Branch Results

 File  .text     Size             Crate Name
 1.2%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_encrypt_avx512
 1.2%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_decrypt_avx512
 0.3%   0.7%  92.5KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.7%  86.6KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  74.7KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.3%   0.5%  70.0KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.4%  51.3KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.4%  48.7KiB              prek prek::run::{{closure}}
 0.2%   0.3%  42.3KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.3%  33.3KiB             prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  30.4KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  30.2KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  28.1KiB      serde_saphyr granit_parser::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble
 0.1%   0.2%  26.3KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  23.7KiB              prek prek::hooks::meta_hooks::MetaHooks::run::{{closure}}
 0.1%   0.2%  23.0KiB      serde_saphyr granit_parser::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
 0.1%   0.2%  21.5KiB      clap_builder clap_builder::parser::parser::Parser::get_matches_with
41.4%  86.1%  10.8MiB                   And 23930 smaller methods. Use -n N to show more.
48.1% 100.0%  12.6MiB                   .text section size, the file size is 26.1MiB

Base Branch Results

 File  .text     Size             Crate Name
 1.2%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_encrypt_avx512
 1.2%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_decrypt_avx512
 0.3%   0.7%  91.9KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.7%  83.9KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  74.8KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.3%   0.5%  70.0KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.4%  51.3KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.4%  48.5KiB              prek prek::run::{{closure}}
 0.2%   0.3%  41.9KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.3%  32.5KiB             prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  30.4KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  29.8KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  28.1KiB      serde_saphyr granit_parser::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble
 0.1%   0.2%  26.5KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  23.2KiB              prek prek::hooks::meta_hooks::MetaHooks::run::{{closure}}
 0.1%   0.2%  23.0KiB      serde_saphyr granit_parser::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
 0.1%   0.2%  21.5KiB      clap_builder clap_builder::parser::parser::Parser::get_matches_with
41.4%  86.1%  10.8MiB                   And 23905 smaller methods. Use -n N to show more.
48.1% 100.0%  12.5MiB                   .text section size, the file size is 26.1MiB

prek-ci-bot · 2026-05-20T03:37:38Z

⚡️ Hyperfine Benchmarks

Summary: 1 regressions, 1 improvements above the 10% threshold.

Environment

OS: Linux 6.17.0-1013-azure
CPU: 4 cores
prek version: prek 0.4.0+24 (5cf1b8a 2026-05-20)
Rust version: rustc 1.95.0 (59807616e 2026-04-14)
Hyperfine version: hyperfine 1.20.0

CLI Commands

Benchmarking basic commands in the main repo:

`prek --version`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base --version`	2.3 ± 0.1	2.2	3.1	1.02 ± 0.06
`prek-head --version`	2.2 ± 0.1	2.0	2.6	1.00

`prek list`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base list`	9.0 ± 0.3	8.7	11.6	1.02 ± 0.05
`prek-head list`	8.8 ± 0.3	8.6	11.3	1.00

`prek validate-config .pre-commit-config.yaml`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base validate-config .pre-commit-config.yaml`	3.1 ± 0.1	3.0	3.6	1.07 ± 0.03
`prek-head validate-config .pre-commit-config.yaml`	2.9 ± 0.0	2.8	3.1	1.00

`prek sample-config`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base sample-config`	2.5 ± 0.1	2.4	2.7	1.06 ± 0.06
`prek-head sample-config`	2.4 ± 0.1	2.3	3.2	1.00

Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

`prek run --all-files (cold - no cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	141.5 ± 5.2	137.0	155.3	1.01 ± 0.04
`prek-head run --all-files`	139.8 ± 2.6	137.0	144.8	1.00

`prek run --all-files (warm - with cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	139.1 ± 2.3	136.2	143.2	1.00
`prek-head run --all-files`	140.9 ± 2.4	136.9	145.7	1.01 ± 0.02

Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

`prek run --all-files (full builtin hook suite)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	140.4 ± 2.6	134.3	146.2	1.00
`prek-head run --all-files`	141.4 ± 3.1	137.3	152.4	1.01 ± 0.03

Individual Hook Performance

Benchmarking each hook individually on the test repo:

`prek run trailing-whitespace --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run trailing-whitespace --all-files`	20.4 ± 0.4	19.8	21.7	1.00
`prek-head run trailing-whitespace --all-files`	27.9 ± 40.3	19.5	241.2	1.37 ± 1.98

⚠️ Warning: Performance regression for prek run trailing-whitespace --all-files: 36.8200% slower

`prek run end-of-file-fixer --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run end-of-file-fixer --all-files`	26.1 ± 1.6	23.5	29.5	1.00
`prek-head run end-of-file-fixer --all-files`	26.4 ± 2.1	23.4	31.5	1.01 ± 0.10

`prek run check-json --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-json --all-files`	11.8 ± 0.3	11.2	12.5	1.02 ± 0.03
`prek-head run check-json --all-files`	11.6 ± 0.2	11.2	12.2	1.00

`prek run check-yaml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-yaml --all-files`	11.0 ± 0.3	10.8	12.3	1.03 ± 0.03
`prek-head run check-yaml --all-files`	10.7 ± 0.1	10.6	11.4	1.00

`prek run check-toml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-toml --all-files`	11.1 ± 0.3	10.6	12.2	1.04 ± 0.04
`prek-head run check-toml --all-files`	10.7 ± 0.3	10.2	11.3	1.00

`prek run check-xml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-xml --all-files`	11.0 ± 0.2	10.6	11.4	1.01 ± 0.03
`prek-head run check-xml --all-files`	10.9 ± 0.3	10.5	11.5	1.00

`prek run detect-private-key --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run detect-private-key --all-files`	17.1 ± 1.3	15.3	20.0	1.03 ± 0.11
`prek-head run detect-private-key --all-files`	16.7 ± 1.3	15.1	19.3	1.00

`prek run fix-byte-order-marker --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run fix-byte-order-marker --all-files`	21.9 ± 1.6	19.5	24.7	1.02 ± 0.11
`prek-head run fix-byte-order-marker --all-files`	21.5 ± 1.6	18.4	24.9	1.00

Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

`prek install-hooks (cold - no cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base install-hooks`	4.6 ± 0.1	4.5	4.7	1.06 ± 0.02
`prek-head install-hooks`	4.3 ± 0.0	4.3	4.4	1.00

`prek install-hooks (warm - with cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base install-hooks`	4.5 ± 0.0	4.5	4.6	1.06 ± 0.01
`prek-head install-hooks`	4.3 ± 0.0	4.3	4.3	1.00

File Filtering/Scoping Performance

Testing different file selection modes:

`prek run (staged files only)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run`	47.0 ± 0.7	46.0	48.8	1.00
`prek-head run`	47.0 ± 0.7	46.1	48.7	1.00 ± 0.02

`prek run --files '*.json' (specific file type)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --files '*.json'`	7.9 ± 0.1	7.8	8.0	1.01 ± 0.02
`prek-head run --files '*.json'`	7.8 ± 0.1	7.6	8.2	1.00

Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

`prek run --dry-run --all-files (measures init overhead)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --dry-run --all-files`	10.1 ± 0.1	9.9	10.4	1.01 ± 0.02
`prek-head run --dry-run --all-files`	10.0 ± 0.2	9.8	10.5	1.00

Meta Hooks Performance

Benchmarking meta hooks separately:

`prek run check-hooks-apply --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-hooks-apply --all-files`	12.4 ± 0.2	12.2	12.9	1.05 ± 0.02
`prek-head run check-hooks-apply --all-files`	11.8 ± 0.1	11.6	12.0	1.00

`prek run check-useless-excludes --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-useless-excludes --all-files`	12.1 ± 0.3	11.2	12.3	1.15 ± 0.05
`prek-head run check-useless-excludes --all-files`	10.5 ± 0.3	10.3	11.7	1.00

✅ Performance improvement for prek run check-useless-excludes --all-files: 13.0400% faster

`prek run identity --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run identity --all-files`	9.8 ± 0.1	9.6	10.1	1.00
`prek-head run identity --all-files`	10.1 ± 1.2	9.4	13.2	1.04 ± 0.12

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [prek](https://github.com/j178/prek) | patch | `0.4.0` → `0.4.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>j178/prek (prek)</summary> ### [`v0.4.1`](https://github.com/j178/prek/blob/HEAD/CHANGELOG.md#041) [Compare Source](j178/prek@v0.4.0...v0.4.1) Released on 2026-05-20. ##### Enhancements - Fix pre-push range after rebase ([#2089](j178/prek#2089)) - Prefer extensions over loose filename tags ([#2092](j178/prek#2092)) - Skip installs for hooks that will not run ([#2103](j178/prek#2103)) ##### Performance - Optimize meta hook file scans ([#2106](j178/prek#2106)) - Reduce run filtering allocations ([#2090](j178/prek#2090)) ##### Contributors - [@j178](https://github.com/j178) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).

Copilot AI review requested due to automatic review settings May 20, 2026 03:30

Copilot started reviewing on behalf of j178 May 20, 2026 03:31 View session

j178 added performance Performance improvements internal Internal changes and removed internal Internal changes labels May 20, 2026

chatgpt-codex-connector Bot reviewed May 20, 2026

View reviewed changes

Comment thread crates/prek/src/cli/run/run.rs

Copilot AI reviewed May 20, 2026

View reviewed changes

j178 force-pushed the meta-hook-scan branch from 72352fb to e155ab2 Compare May 20, 2026 03:50

Optimize meta hook file scans

2198a91

Copilot AI review requested due to automatic review settings May 20, 2026 03:55

j178 force-pushed the meta-hook-scan branch from e155ab2 to 2198a91 Compare May 20, 2026 03:55

Copilot started reviewing on behalf of j178 May 20, 2026 03:55 View session

j178 merged commit 3c26faf into master May 20, 2026
33 of 34 checks passed

j178 deleted the meta-hook-scan branch May 20, 2026 03:59

j178 review requested due to automatic review settings May 20, 2026 04:15

BrewTestBot mentioned this pull request May 20, 2026

prek 0.4.1 Homebrew/homebrew-core#283700

Open

Conversation

j178 commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

prek-ci-bot Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Cargo Bloat Comparison

Head Branch Results

Base Branch Results

Uh oh!

prek-ci-bot Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚡️ Hyperfine Benchmarks

prek --version

prek list

prek validate-config .pre-commit-config.yaml

prek sample-config

prek run --all-files (cold - no cache)

prek run --all-files (warm - with cache)

prek run --all-files (full builtin hook suite)

prek run trailing-whitespace --all-files

prek run end-of-file-fixer --all-files

prek run check-json --all-files

prek run check-yaml --all-files

prek run check-toml --all-files

prek run check-xml --all-files

prek run detect-private-key --all-files

prek run fix-byte-order-marker --all-files

prek install-hooks (cold - no cache)

prek install-hooks (warm - with cache)

prek run (staged files only)

prek run --files '*.json' (specific file type)

prek run --dry-run --all-files (measures init overhead)

prek run check-hooks-apply --all-files

prek run check-useless-excludes --all-files

prek run identity --all-files

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

j178 commented May 20, 2026 •

edited

Loading

codecov Bot commented May 20, 2026 •

edited

Loading

prek-ci-bot Bot commented May 20, 2026 •

edited

Loading

prek-ci-bot Bot commented May 20, 2026 •

edited

Loading

`prek --version`

`prek list`

`prek validate-config .pre-commit-config.yaml`

`prek sample-config`

`prek run --all-files (cold - no cache)`

`prek run --all-files (warm - with cache)`

`prek run --all-files (full builtin hook suite)`

`prek run trailing-whitespace --all-files`

`prek run end-of-file-fixer --all-files`

`prek run check-json --all-files`

`prek run check-yaml --all-files`

`prek run check-toml --all-files`

`prek run check-xml --all-files`

`prek run detect-private-key --all-files`

`prek run fix-byte-order-marker --all-files`

`prek install-hooks (cold - no cache)`

`prek install-hooks (warm - with cache)`

`prek run (staged files only)`

`prek run --files '*.json' (specific file type)`

`prek run --dry-run --all-files (measures init overhead)`

`prek run check-hooks-apply --all-files`

`prek run check-useless-excludes --all-files`

`prek run identity --all-files`