Skip to content

Update Rust to 1.96#2134

Merged
j178 merged 1 commit into
masterfrom
rust
May 29, 2026
Merged

Update Rust to 1.96#2134
j178 merged 1 commit into
masterfrom
rust

Conversation

@j178
Copy link
Copy Markdown
Owner

@j178 j178 commented May 29, 2026

No description provided.

Copilot AI review requested due to automatic review settings May 29, 2026 07:23
@j178 j178 added the internal Internal changes label May 29, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s Rust toolchain configuration and workspace MSRV metadata.

Changes:

  • Pins rust-toolchain.toml to Rust 1.96.
  • Raises the workspace rust-version metadata to 1.94.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
rust-toolchain.toml Updates the default Rust toolchain channel.
Cargo.toml Updates the workspace Rust version metadata inherited by crates.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.42%. Comparing base (1815fc5) to head (7dc2a3b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2134      +/-   ##
==========================================
- Coverage   92.42%   92.42%   -0.01%     
==========================================
  Files         121      121              
  Lines       25473    25473              
==========================================
- Hits        23544    23543       -1     
- Misses       1929     1930       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@prek-ci-bot
Copy link
Copy Markdown

prek-ci-bot Bot commented May 29, 2026

📦 Cargo Bloat Comparison

Binary size change: +0.76% (26.2 MiB → 26.4 MiB)

Expand for cargo-bloat output

Head Branch Results

 File  .text     Size             Crate Name
 1.2%   2.5% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_encrypt_avx512
 1.2%   2.5% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_decrypt_avx512
 0.3%   0.7%  90.0KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.7%  85.1KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.5%  69.8KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.5%  60.7KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.4%  49.4KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.4%  48.3KiB              prek prek::run::{{closure}}
 0.2%   0.3%  42.7KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.3%  33.1KiB             prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  30.6KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  30.1KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  28.1KiB      serde_saphyr granit_parser::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble
 0.1%   0.2%  26.0KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  25.1KiB              prek prek::hooks::meta_hooks::MetaHooks::run::{{closure}}
 0.1%   0.2%  23.0KiB      serde_saphyr granit_parser::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
 0.1%   0.2%  21.5KiB      clap_builder clap_builder::parser::parser::Parser::get_matches_with
41.9%  86.4%  11.0MiB                   And 24102 smaller methods. Use -n N to show more.
48.4% 100.0%  12.8MiB                   .text section size, the file size is 26.4MiB

Base Branch Results

 File  .text     Size             Crate Name
 1.2%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_encrypt_avx512
 1.2%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_41_0_aes_gcm_decrypt_avx512
 0.3%   0.7%  90.4KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  81.5KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.5%  69.9KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.5%  60.9KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.4%  51.3KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.3%  43.0KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.3%  35.9KiB              prek prek::run::{{closure}}
 0.1%   0.3%  33.1KiB             prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  30.4KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  29.6KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  28.1KiB      serde_saphyr granit_parser::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_41_0_edwards25519_scalarmuldouble
 0.1%   0.2%  26.4KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  23.9KiB              prek prek::hooks::meta_hooks::MetaHooks::run::{{closure}}
 0.1%   0.2%  23.0KiB      serde_saphyr granit_parser::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
 0.1%   0.2%  21.5KiB      clap_builder clap_builder::parser::parser::Parser::get_matches_with
41.6%  86.4%  10.9MiB                   And 24017 smaller methods. Use -n N to show more.
48.1% 100.0%  12.6MiB                   .text section size, the file size is 26.2MiB

@prek-ci-bot
Copy link
Copy Markdown

prek-ci-bot Bot commented May 29, 2026

⚡️ Hyperfine Benchmarks

Summary: 2 regressions, 1 improvements above the 10% threshold.

Environment
  • OS: Linux 6.17.0-1015-azure
  • CPU: 4 cores
  • prek version: prek 0.4.3+3 (6045bec 2026-05-29)
  • Rust version: rustc 1.96.0 (ac68faa20 2026-05-25)
  • Hyperfine version: hyperfine 1.20.0
CLI Commands

Benchmarking basic commands in the main repo:

prek --version

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base --version 2.3 ± 0.1 2.2 2.8 1.00
prek-head --version 2.4 ± 0.1 2.2 2.9 1.01 ± 0.06

prek list

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base list 9.1 ± 0.1 8.8 9.8 1.00
prek-head list 9.5 ± 1.1 8.9 16.5 1.04 ± 0.12

prek validate-config .pre-commit-config.yaml

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base validate-config .pre-commit-config.yaml 3.2 ± 0.0 3.1 3.3 1.00 ± 0.03
prek-head validate-config .pre-commit-config.yaml 3.2 ± 0.1 3.0 3.6 1.00

prek sample-config

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base sample-config 2.6 ± 0.0 2.5 2.7 1.00
prek-head sample-config 2.7 ± 0.1 2.5 2.9 1.02 ± 0.03
Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

prek run --all-files (cold - no cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 86.5 ± 3.9 79.8 90.7 1.00
prek-head run --all-files 87.1 ± 4.1 79.6 92.1 1.01 ± 0.07

prek run --all-files (warm - with cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 84.5 ± 5.0 74.5 93.4 1.00
prek-head run --all-files 85.2 ± 4.9 74.6 95.9 1.01 ± 0.08
Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

prek run --all-files (full builtin hook suite)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 86.9 ± 4.2 76.8 97.9 1.00 ± 0.07
prek-head run --all-files 86.5 ± 4.6 76.5 97.9 1.00
Individual Hook Performance

Benchmarking each hook individually on the test repo:

prek run trailing-whitespace --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run trailing-whitespace --all-files 22.1 ± 1.3 20.6 25.4 1.02 ± 0.10
prek-head run trailing-whitespace --all-files 21.6 ± 1.8 19.8 28.9 1.00

prek run end-of-file-fixer --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run end-of-file-fixer --all-files 28.9 ± 2.3 24.8 33.3 1.00
prek-head run end-of-file-fixer --all-files 28.9 ± 3.1 24.3 36.0 1.00 ± 0.13

prek run check-json --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-json --all-files 8.3 ± 0.4 7.7 9.5 1.00
prek-head run check-json --all-files 8.3 ± 0.4 7.7 9.7 1.00 ± 0.07

prek run check-yaml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-yaml --all-files 8.1 ± 0.3 7.6 8.8 1.00 ± 0.06
prek-head run check-yaml --all-files 8.1 ± 0.4 7.6 9.2 1.00

prek run check-toml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-toml --all-files 8.4 ± 0.4 7.6 9.3 1.00
prek-head run check-toml --all-files 8.5 ± 0.5 7.7 9.8 1.01 ± 0.08

prek run check-xml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-xml --all-files 8.3 ± 0.3 7.7 8.9 1.00 ± 0.06
prek-head run check-xml --all-files 8.3 ± 0.3 7.7 9.1 1.00

prek run detect-private-key --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run detect-private-key --all-files 15.7 ± 2.0 13.0 19.7 1.04 ± 0.16
prek-head run detect-private-key --all-files 15.1 ± 1.3 12.5 18.1 1.00

prek run fix-byte-order-marker --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run fix-byte-order-marker --all-files 23.9 ± 1.8 20.7 27.1 1.00
prek-head run fix-byte-order-marker --all-files 29.7 ± 18.0 19.9 103.0 1.24 ± 0.76

⚠️ Warning: Performance regression for prek run fix-byte-order-marker --all-files: 24.3300% slower

Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

prek install-hooks (cold - no cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base install-hooks 4.7 ± 0.1 4.6 4.8 1.00 ± 0.02
prek-head install-hooks 4.7 ± 0.1 4.6 4.8 1.00

prek install-hooks (warm - with cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base install-hooks 4.6 ± 0.1 4.6 4.7 1.00
prek-head install-hooks 4.7 ± 0.1 4.7 4.9 1.02 ± 0.02
File Filtering/Scoping Performance

Testing different file selection modes:

prek run (staged files only)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run 41.6 ± 2.0 39.4 48.0 1.01 ± 0.05
prek-head run 41.4 ± 1.0 39.9 43.2 1.00

prek run --files '*.json' (specific file type)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --files '*.json' 8.4 ± 0.1 8.3 8.7 1.00
prek-head run --files '*.json' 9.5 ± 2.3 8.4 17.9 1.13 ± 0.27

⚠️ Warning: Performance regression for prek run --files '*.json' (specific file type): 12.6000% slower

Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

prek run --dry-run --all-files (measures init overhead)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --dry-run --all-files 7.3 ± 0.2 7.1 8.1 1.02 ± 0.03
prek-head run --dry-run --all-files 7.2 ± 0.1 7.0 7.4 1.00
Meta Hooks Performance

Benchmarking meta hooks separately:

prek run check-hooks-apply --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-hooks-apply --all-files 13.0 ± 0.2 12.7 13.5 1.15 ± 0.02
prek-head run check-hooks-apply --all-files 11.3 ± 0.1 11.2 11.6 1.00

✅ Performance improvement for prek run check-hooks-apply --all-files: 12.7600% faster

prek run check-useless-excludes --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-useless-excludes --all-files 11.2 ± 0.1 11.1 11.4 1.00
prek-head run check-useless-excludes --all-files 11.2 ± 0.1 11.1 11.4 1.00 ± 0.01

prek run identity --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run identity --all-files 10.6 ± 0.1 10.5 10.8 1.00
prek-head run identity --all-files 10.7 ± 0.2 10.3 11.3 1.01 ± 0.02

@j178 j178 merged commit ce0d8b3 into master May 29, 2026
38 checks passed
@j178 j178 deleted the rust branch May 29, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Internal changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants