Fix progress insertion after collapsed rows#2292
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2292 +/- ##
=======================================
Coverage 93.13% 93.13%
=======================================
Files 127 127
Lines 28094 28167 +73
=======================================
+ Hits 26164 26234 +70
- Misses 1930 1933 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR adjusts the CLI hook-run progress reporter’s insertion logic so new progress rows are anchored to the correct “visual tail” (running output tails and latest visible completed rows), preventing collapsed summaries from becoming the next insertion anchor and causing row reordering/collapse corruption.
Changes:
- Replace per-project
last_line/active_tailtracking withrunning_tailsand a computedinsertion_anchor(). - Place the hidden summary line at the collapsed-row anchor (instead of always near the header), and keep anchors based on visible/running lines.
- Rework completion/output flows and update tests to reflect the new anchoring behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1148e532d7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
📦 Cargo Bloat ComparisonBinary size change: -0.74% (26.9 MiB → 26.7 MiB) Expand for cargo-bloat outputHead Branch ResultsBase Branch Results |
⚡️ Hyperfine BenchmarksSummary: 0 regressions, 0 improvements above the 10% threshold. Environment
CLI CommandsBenchmarking basic commands in the main repo:
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base --version |
1.9 ± 0.1 | 1.8 | 2.6 | 1.00 ± 0.06 |
prek-head --version |
1.9 ± 0.1 | 1.8 | 2.1 | 1.00 |
prek list
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base list |
7.5 ± 0.1 | 7.3 | 7.7 | 1.00 |
prek-head list |
8.1 ± 5.9 | 7.3 | 66.0 | 1.08 ± 0.78 |
prek validate-config .pre-commit-config.yaml
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base validate-config .pre-commit-config.yaml |
2.7 ± 0.1 | 2.6 | 2.9 | 1.00 |
prek-head validate-config .pre-commit-config.yaml |
2.7 ± 0.0 | 2.6 | 2.8 | 1.01 ± 0.03 |
prek sample-config
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base sample-config |
2.2 ± 0.1 | 2.1 | 2.3 | 1.01 ± 0.03 |
prek-head sample-config |
2.1 ± 0.0 | 2.1 | 2.2 | 1.00 |
Cold vs Warm Runs
Comparing first run (cold) vs subsequent runs (warm cache):
prek run --all-files (cold - no cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
58.3 ± 2.6 | 54.6 | 62.5 | 1.00 |
prek-head run --all-files |
58.6 ± 2.2 | 56.1 | 62.0 | 1.01 ± 0.06 |
prek run --all-files (warm - with cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
58.3 ± 2.5 | 55.2 | 63.1 | 1.00 |
prek-head run --all-files |
59.8 ± 2.7 | 54.3 | 63.9 | 1.03 ± 0.06 |
Full Hook Suite
Running the builtin hook suite on the benchmark workspace:
prek run --all-files (full builtin hook suite)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
58.5 ± 2.4 | 54.2 | 63.5 | 1.00 |
prek-head run --all-files |
58.7 ± 2.1 | 55.1 | 63.4 | 1.00 ± 0.05 |
Individual Hook Performance
Benchmarking each hook individually on the test repo:
prek run trailing-whitespace --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run trailing-whitespace --all-files |
15.9 ± 0.4 | 15.4 | 16.6 | 1.01 ± 0.03 |
prek-head run trailing-whitespace --all-files |
15.8 ± 0.2 | 15.3 | 16.3 | 1.00 |
prek run end-of-file-fixer --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run end-of-file-fixer --all-files |
20.2 ± 1.4 | 18.5 | 23.0 | 1.00 |
prek-head run end-of-file-fixer --all-files |
20.4 ± 1.6 | 18.6 | 24.7 | 1.01 ± 0.10 |
prek run check-json --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-json --all-files |
6.4 ± 0.2 | 6.0 | 6.8 | 1.01 ± 0.04 |
prek-head run check-json --all-files |
6.3 ± 0.2 | 6.1 | 6.8 | 1.00 |
prek run check-yaml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-yaml --all-files |
6.2 ± 0.1 | 6.0 | 6.4 | 1.01 ± 0.02 |
prek-head run check-yaml --all-files |
6.1 ± 0.1 | 6.0 | 6.4 | 1.00 |
prek run check-toml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-toml --all-files |
6.4 ± 0.6 | 5.9 | 9.1 | 1.02 ± 0.09 |
prek-head run check-toml --all-files |
6.2 ± 0.2 | 5.9 | 6.7 | 1.00 |
prek run check-xml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-xml --all-files |
6.2 ± 0.2 | 6.0 | 6.7 | 1.00 |
prek-head run check-xml --all-files |
6.3 ± 0.2 | 5.9 | 6.8 | 1.00 ± 0.04 |
prek run detect-private-key --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run detect-private-key --all-files |
10.5 ± 0.8 | 9.3 | 12.1 | 1.01 ± 0.11 |
prek-head run detect-private-key --all-files |
10.4 ± 0.8 | 9.3 | 12.4 | 1.00 |
prek run fix-byte-order-marker --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run fix-byte-order-marker --all-files |
14.4 ± 0.7 | 13.2 | 15.9 | 1.02 ± 0.06 |
prek-head run fix-byte-order-marker --all-files |
14.1 ± 0.5 | 13.4 | 15.7 | 1.00 |
Installation Performance
Benchmarking hook installation (fast path hooks skip Python setup):
prek install-hooks (cold - no cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base install-hooks |
3.8 ± 0.0 | 3.8 | 3.9 | 1.01 ± 0.02 |
prek-head install-hooks |
3.8 ± 0.1 | 3.7 | 3.8 | 1.00 |
prek install-hooks (warm - with cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base install-hooks |
3.8 ± 0.0 | 3.8 | 3.9 | 1.00 |
prek-head install-hooks |
3.9 ± 0.1 | 3.9 | 4.0 | 1.02 ± 0.02 |
File Filtering/Scoping Performance
Testing different file selection modes:
prek run (staged files only)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run |
30.2 ± 0.6 | 29.4 | 31.9 | 1.00 |
prek-head run |
30.5 ± 0.7 | 29.4 | 31.9 | 1.01 ± 0.03 |
prek run --files '*.json' (specific file type)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --files '*.json' |
6.6 ± 0.1 | 6.5 | 6.7 | 1.00 |
prek-head run --files '*.json' |
6.7 ± 0.0 | 6.6 | 6.8 | 1.00 ± 0.01 |
Workspace Discovery & Initialization
Benchmarking hook discovery and initialization overhead:
prek run --dry-run --all-files (measures init overhead)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --dry-run --all-files |
5.7 ± 0.1 | 5.6 | 6.0 | 1.01 ± 0.02 |
prek-head run --dry-run --all-files |
5.7 ± 0.1 | 5.5 | 5.7 | 1.00 |
Meta Hooks Performance
Benchmarking meta hooks separately:
prek run check-hooks-apply --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-hooks-apply --all-files |
9.6 ± 0.5 | 8.8 | 10.0 | 1.08 ± 0.06 |
prek-head run check-hooks-apply --all-files |
8.9 ± 0.1 | 8.8 | 9.2 | 1.00 |
prek run check-useless-excludes --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-useless-excludes --all-files |
8.8 ± 0.1 | 8.7 | 8.9 | 1.00 |
prek-head run check-useless-excludes --all-files |
8.9 ± 0.1 | 8.7 | 9.2 | 1.01 ± 0.02 |
prek run identity --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run identity --all-files |
8.3 ± 0.1 | 8.2 | 8.4 | 1.00 |
prek-head run identity --all-files |
8.3 ± 0.1 | 8.2 | 8.5 | 1.00 ± 0.01 |
1148e53 to
b039df3
Compare
b039df3 to
2042732
Compare
Summary
Context
Follow-up to #2291. A collapsed summary could become the next insertion anchor while an older hook in the same project was still running, which allowed later hooks to render above older running rows and corrupt later collapse order.