Fix autoupdate rev rendering for "float-like" version numbers
#867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A version number could look like a float, e.g., 0.49 is a valid version number. Serde YAML serialization already renders such version numbers in quotes so types match the expectation. When doing an autoupdate we were explicitly adding more quotes if they were present in the input. This could have caused incorrect quoting if existing quoting clashed with serde's quoting style, e.g., if `"` where used but serde defaulted to quoting with `'`. This patch removes any extra quoting here and fully defers to serde. Closes j178#866.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #867 +/- ##
==========================================
- Coverage 89.53% 89.50% -0.03%
==========================================
Files 60 60
Lines 11204 11201 -3
==========================================
- Hits 10031 10025 -6
- Misses 1173 1176 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Thanks, I think this makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A version number could look like a float, e.g., 0.49 is a valid version number. Serde YAML serialization already renders such version numbers in quotes so types match the expectation. When doing an autoupdate we were explicitly adding more quotes if they were present in the input. This could have caused incorrect quoting if existing quoting clashed with serde's quoting style, e.g., if
"where used but serde defaulted to quoting with'.This patch removes any extra quoting here and fully defers to serde.
Closes #866.