Fix plugins {...} syntax by allowing reordering of plugin loading

[brunobowden]

• Creates new throwIfNoJavaPlugin(…) method
• Move the above check from project.with to project.afterEvaluate
• Add another check in srcDirs(…) method as a double check

This allows the j2objc to be loaded before the java plugin… but
still produces meaningful errors if the java plugin is missing. This
allows the use of the plugins syntax and should fix #130.

This will need to be verified after a new plugin is published. Likely
version 0.3.0.

plugins {
    id "com.github.j2objccontrib.j2objcgradle" version "0.3.0-alpha"
}

apply 'java'

[brunobowden]

@advayDev1, @confile - This is an important change that should allow use of the plugins {...} syntax. I've tested a number of error scenarios, e.g. the plugin not loaded and it gives an intelligent error message.

Once this change is merged in, I'll spin a new version and verify that it fixes #130. After that, I'll work through some other bugs, including any issues that @confile is seeing. Then do another version and finally promote that in a few places.

[confile]

@brunobowden Sound great. I just have a look at it. Sorry for raising so many error but I still have a lot of problems with the new plugin.

[confile]

LGTM

[brunobowden]

@confile - making you happy is a good path to making many other people
happy as well

On Sat, Jun 20, 2015 at 9:55 AM Michael Gorski notifications@github.com
wrote:

LGTM

—
Reply to this email directly or view it on GitHub
#201 (comment)
.

[confile]

@brunobowden Thanks!

[advayDev1]

LGTM. There's some odd smart-quotes thing going in your comment. Hopefully that isn't in the code too:

“0.3.0-alpha"

[brunobowden]

Fixed weird smart quotes - probably from using the GitHub client, though I still find it useful for visual diffs. Added unit test for throw without Java plugin and TODO for test for no throw when Java plugin present.

[brunobowden]

Fixes #130

... I'll try being confident ;-) Verification later tonight.