fix: prevent header from scrolling away by constraining layout height#10
Merged
fix: prevent header from scrolling away by constraining layout height#10
Conversation
The SidebarProvider wrapper used `min-h-svh` which allowed it to grow with content, preventing SidebarInset from becoming a scroll container. This caused the header to scroll out of view. - Add `h-svh` to SidebarProvider to fix the height chain - Set SidebarInset to `overflow-hidden` and wrap Editor in a scrollable div - Replace Editor's `<main>` with `<div>` to resolve semantic nesting - Simplify note selection by consolidating localStorage sync into `selectNote` Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
h-svhto SidebarProvider, establishing a proper height chain so SidebarInset becomes the scroll container<main>with<div>to resolve semantic HTML nestingselectNotecallbackTest plan
🤖 Generated with Claude Code