Conversation
…tton clicks The handleWrapperClick guard only checked for `.bn-editor`, but BlockNote UI elements (formatting toolbar, color picker, menus, etc.) are rendered as siblings of `.bn-editor` inside `.bn-container`. Clicks on these elements would pass the guard, causing the cursor to move to the last block and the selection to clear, which closed the toolbar before the color picker could open. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handleWrapperClickguard inEditor.tsxthat was dismissing the formatting toolbar when clicking toolbar buttons (e.g. the color picker).bn-editor, but the formatting toolbar and its overlays are rendered as siblings of.bn-editorinside.bn-container— so clicks on toolbar buttons were not caught by the guardtarget.closest('.bn-editor')totarget.closest('.bn-container')so that all BlockNote UI elements (editor, toolbars, menus, color picker dropdowns, etc.) are excluded from the padding-area click handlerRoot cause
The editor wrapper has a
pb-[60vh]padding zone. Clicking this area callseditor.setTextCursorPosition(lastBlock, 'end')to focus the editor. The guard only excluded clicks inside.bn-editor(the contenteditable), but the formatting toolbar, color picker, and other BlockNote UI are rendered outside.bn-editor(as siblings inside.bn-container). When clicking the color button:pointerup→ dropdown opens viaMenuTriggerWithPointerUphackclick→ bubbles to wrapper →handleWrapperClickruns (passes the.bn-editorguard)editor.setTextCursorPosition(lastBlock, 'end')→ selection clearsshouldShow()returnsfalse→ toolbar unmounts → dropdown disappearsTest plan
cargo buildsucceeds🤖 Generated with Claude Code