feat(editor): allow inline code to coexist with highlight and other marks#120
Merged
feat(editor): allow inline code to coexist with highlight and other marks#120
Conversation
…arks Override TipTap Code mark `excludes` from `'_'` (all) to `''` (none) so inline code can be combined with backgroundColor, textColor, bold, italic, underline, and strikethrough — matching Notion behaviour. Reorder styleSpecs so `code` is declared last, placing `<code>` inside the highlight `<span>` in the DOM. This keeps the highlight box at normal text height instead of shrinking to the smaller code font-size. Add CSS rules for code-inside-highlight: semi-transparent code background in light mode, dark opaque background in dark mode, with a subtle ring for visual separation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow inline code (
<code>) to coexist with highlight (backgroundColor), textColor, bold, italic, underline, and strikethrough marks — matching Notion behaviour.Key changes:
excludesfrom'_'(all) to''(none) viaCode.extend({ excludes: '' })styleSpecssocodeis declared last, placing<code>inside the highlight<span>in the DOM — keeps highlight box at normal text heightRelated Issue
N/A — standalone enhancement
Type of Change
Breaking Changes
None
Test
npm run tauri devChecklist