refactor: move save status indicator to sticky overlay in editor area#14
Merged
refactor: move save status indicator to sticky overlay in editor area#14
Conversation
Move SaveStatusIndicator from the auto-hide header to a sticky overlay inside the scroll container so it remains visible regardless of header state. Use invisible placeholder to prevent layout shifts when the indicator appears/disappears. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SaveStatusIndicatorfrom the auto-hide header to astickyoverlay inside the scroll container so it remains visible regardless of header visibilitynullreturn with aninvisibleplaceholder to prevent layout shifts when the indicator appears/disappearsuseEffectby usingisTimerActiveRefinstead of readingdisplaystateDetails
SaveStatusIndicator changes
<span>elements into a single return with conditionalinvisibleclass viacn()displaystate read insideuseEffectwith anisTimerActiveRefref to avoid stale closures and satisfyreact-hooks/exhaustive-depsclearTimeoutnon-null assertion by usingundefinedinstead ofnullfor the ref typeApp.tsx changes
SaveStatusIndicatorfrom the<header>elementsticky top-5overlay inside the scroll container withpointer-events-noneso it doesn't interfere with scrollingcn()conditional class patternTest plan
pointer-events-none)🤖 Generated with Claude Code