fix: handle Escape key in search panel inputs to close the panel#42
Merged
fix: handle Escape key in search panel inputs to close the panel#42
Conversation
The search panel's onKeyDown handlers called stopPropagation on all key events, preventing Escape from reaching the global window listener in useSearchReplace. This fix adds Escape handling directly in both the search and replace inputs, with stopImmediatePropagation to avoid duplicate close() calls. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windowlistener inuseSearchReplacewas blocked bystopPropagation()on every keydown eventstopAndCloseandstopPropagatehelper functions to reduce duplication across the two input handlersTest plan
Ctrl+Fto open the search panelEscape— panel should closeEscape— panel should closeCtrl+F, navigate matches withEnter/Shift+Enter— panel should stay openEscapewhen search panel is closed — no side effects🤖 Generated with Claude Code