Conversation
… cascade priority
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix dark mode editor background not matching the app's dark theme.
Problem
The
.dark .bn-editorCSS rule was declared inside Tailwind's@layer base, which has lower specificity than BlockNote's default styles defined outside any@layer. As a result, BlockNote's--bn-colors-editor-background(#1f1f1f) took precedence over the app's--backgroundtoken in dark mode, causing the editor background to appear lighter than the surrounding UI.Changes
.dark .bn-editor { background-color: var(--background); }from inside@layer baseto outside it, so the rule wins the CSS cascade over BlockNote's defaults@layer baseTesting
oklch(0.145 0 0))npm run buildpassescargo buildpasses