fix: prevent scroll when ':' triggers emoji suggestion menu#71
Merged
fix: prevent scroll when ':' triggers emoji suggestion menu#71
Conversation
Only fire the scroll-to-cursor callback when the suggestion menu is
opened by the slash ('/') command palette. Other menus (e.g. the emoji
picker triggered by ':') share the same suggestionMenu extension store,
so we now guard on triggerCharacter === '/' before calling notifyOpen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
suggestionMenuextension のストア購読でtriggerCharacterを確認するよう修正triggerCharacter === '/'のときのみスクロールを実行:で絵文字ピッカーが開いた際の意図しないスクロールを防止Root Cause
BlockNote の
suggestionMenu拡張は/（スラッシュコマンド）と:（絵文字ピッカー）の両メニューが同じストアを共有している。旧コードはtriggerCharacterをチェックしていなかったため、:入力時にもonSuggestionMenuOpenコールバックが呼ばれ、スクロールが発生していた。Changes
src/features/editor/ui/Editor.tsxstateの型定義にtriggerCharacter?: stringを追加triggerCharacter === '/'の場合のみスクロールを実行するガードを追加Testing
:を入力して絵文字ピッカーが開いてもスクロールされないことを確認/を入力してコマンドパレットが開いたときは従来通りスクロールされることを確認