fix: prevent Ctrl+Z from reverting to default content after note load#74
Merged
fix: prevent Ctrl+Z from reverting to default content after note load#74
Conversation
When a note is loaded from the database, `replaceBlocks` dispatches a ProseMirror transaction that prosemirror-history records as an undoable step. Pressing Ctrl+Z after loading would revert the editor back to the default "Welcome to Scripta" content. This change wraps all content-loading transactions (replaceBlocks and backfillImageCaptions) with `withSuppressedHistory`, which temporarily patches `view.dispatch` to add `addToHistory: false` metadata. The original dispatch is restored via try/finally. Also extracts the duplicated image-caption fallback logic into a shared `getImageCaptionFallback` helper. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
replaceBlocks/backfillImageCaptions)getImageCaptionFallbackhelperProblem
After opening a note, pressing Ctrl+Z would revert the editor content back to the default "Welcome to Scripta" blocks. This happened because
replaceBlocksdispatched a ProseMirror transaction thatprosemirror-historyrecorded as an undoable step.Solution
Added
withSuppressedHistory(view, fn)which temporarily patchesview.dispatchto attachaddToHistory: falsemetadata on every transaction during the callback. The original dispatch is always restored viatry/finally.Test plan
🤖 Generated with Claude Code