fix: correct Ctrl+J/K movement when image block is focused#76
Merged
Conversation
NodeSelection (used for image/file blocks) keeps $head at the node's end position, so Selection.findFrom($head, dir) was re-selecting the same node instead of jumping to the neighbour block. Detect NodeSelection with instanceof and resolve a position just outside the node ($head.after/before at the node's depth) before calling findFrom, matching the existing textblock-boundary behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NodeSelection(used when an atomic block is selected) keeps$headat the node's trailing position; callingSelection.findFrom($head, -1)re-selected the same node instead of jumping to the previous blockNodeSelectionviainstanceofand resolve a position just outside the node ($head.after/$head.beforeat the node depth) before callingfindFrom, consistent with the existing textblock-boundary logicChanges
src/features/editor/lib/cursorVimKeys.tsNodeSelectionimport; special-case node selections in vertical movementReproduction