fix(tag-release): use GitHub App token to restore release.yml trigger#15
Merged
fix(tag-release): use GitHub App token to restore release.yml trigger#15
Conversation
Addresses zizmor secrets-outside-env advisory (rule zizmor/secrets-outside-env). Binding the tag-release job to a named environment means RELEASE_BOT_PRIVATE_KEY is only attached after the environment's branch-policy check (main only) passes, adding a GitHub-side enforcement on top of the existing if: guard. Refs: #14
j7an
added a commit
that referenced
this pull request
Apr 12, 2026
fix(tag-release): use GitHub App token to restore release.yml trigger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #14. Replaces the default
GITHUB_TOKENused bytag-release.ymlwith a short-lived GitHub App installation token, so tag-push events propagate andrelease.yml(which ison: push: tags) fires as intended.The reactive model in
release.ymlis preserved — it still runs on any tag push, including CLI pushes from a developer machine. Only the pusher identity in the upstream workflow changes.Changes
.github/workflows/tag-release.yml:vars.RELEASE_BOT_APP_IDis empty. Runs before any side effects.actions/create-github-app-token@1b10c78c7865c340bc4f6099eb2f838309f1e8c3 # v3.1.1, SHA-pinned to match the existing convention.token: \${{ steps.app-token.outputs.token }}, which persists the App token as the push credential in.git/config. The subsequentgit pushstep body is unchanged.README.md— new## Release Bot App setupsection documenting required config (vars.RELEASE_BOT_APP_ID,secrets.RELEASE_BOT_PRIVATE_KEY), one-time provisioning steps, verification, and rotation. The preflight error message links to this section's auto-anchor.How it works
GitHub's documented recursion guard prevents events caused by `GITHUB_TOKEN` from creating new workflow runs. That's why `release.yml` has been dormant since it was introduced. Switching the pusher to a GitHub App installation token bypasses the guard — App-triggered events propagate normally.
The CLI escape hatch (`git push origin v1.4.0` from a developer laptop) continues to work for free: laptop credentials were never `GITHUB_TOKEN` in the first place.
Test plan
Prereqs already in place
Notes for reviewers