Add obsolete elements and attributes by j9t · Pull Request #11 · j9t/obsohtml

j9t · 2024-11-29T10:41:35Z

Summary by CodeRabbit

New Features
- Updated lists of obsolete HTML elements and attributes, including the addition of 'param', 'rb', and 'rtc'.
- Replaced 'background' with 'bgcolor' in obsolete attributes while maintaining 'bgcolor'.
Chores
- Updated project version from 1.6.3 to 1.7.0 in the package.json file.

Expanded the obsolete HTML elements list to include 'param', 'rb', and 'rtc'. Updated the attributes list with 'background' for more comprehensive checking of obsolete/proprietary HTML usage. (This commit message was AI-generated.) Signed-off-by: Jens Oliver Meiert <jens@meiert.com>

Update package.json and package-lock.json to reflect the new version 1.7.0. This version bump indicates the addition of new features or improvements, ensuring compatibility with the updated package contents. (This commit message was AI-generated.) Signed-off-by: Jens Oliver Meiert <jens@meiert.com>

coderabbitai · 2024-11-29T10:41:42Z

Walkthrough

The changes involve updates to the bin/obsohtml.js file, specifically in the lists of obsolete HTML elements and attributes. New elements 'param', 'rb', and 'rtc' have been added, and the 'background' attribute has been replaced with 'bgcolor', while 'bgcolor' remains. The order of some attributes has been modified. Additionally, the package.json file has been updated to reflect a new version number, changing from 1.6.3 to 1.7.0. No other modifications were made to the project's structure or functionality.

Changes

File	Change Summary
bin/obsohtml.js	- Added 'param', 'rb', and 'rtc' to `obsoleteElements` array.
	- Replaced 'background' with 'bgcolor' in `obsoleteAttributes` array, while keeping 'bgcolor'.
	- Changed order of attributes, moving 'marginwidth' and 'marginheight' after 'background'.
package.json	- Updated version from `1.6.3` to `1.7.0`.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Script
    participant Directory
    participant Log

    User->>Script: Start script with command line options
    Script->>Directory: Traverse directory
    Directory->>Script: Check for obsolete elements and attributes
    Script->>Log: Log skipped directories and files
    Script->>User: Return results

Warning

Rate limit exceeded

@j9t has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 49 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between f5d5258 and 3783a83.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between f5d5258 and 3783a83.

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (2)

bin/obsohtml.js (1 hunks)
package.json (1 hunks)

✅ Files skipped from review due to trivial changes (1)

package.json

bin/obsohtml.js

j9t added 2 commits November 29, 2024 11:39

coderabbitai bot reviewed Nov 29, 2024

View reviewed changes

bin/obsohtml.js Show resolved Hide resolved

j9t merged commit 62b51bb into main Nov 29, 2024

j9t deleted the refactor/elements branch February 16, 2026 18:20

coderabbitai bot mentioned this pull request Feb 23, 2026

Optimize package #35

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add obsolete elements and attributes#11

Add obsolete elements and attributes#11
j9t merged 2 commits intomainfrom
refactor/elements

j9t commented Nov 29, 2024 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Nov 29, 2024 •

edited

Loading

Rate limit exceeded

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

j9t commented Nov 29, 2024 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Nov 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Rate limit exceeded

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

j9t commented Nov 29, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 29, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)