Calculate the total line height of a text#1068
Merged
pspeed42 merged 2 commits intoApr 14, 2019
Merged
Conversation
…e the total line height from the font line height and total line count. Include a test case with alignment examples. fixes: #363
Contributor
|
Thank you for the fix! |
Contributor
|
It looks like you might be only the second person in the world that has made a change to BitmapText classes without breaking something else. I mean, time will tell, I guess. :) Looks good to me, though (and I'm the only other person whose done it... and I did it by failing 5-10 times before that.) |
Member
|
Re-target to v3.3.0 due to the risk of breaking existing applications. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes: #363
The
totalHeightwas calculated using this line:This always resulted in
totalHeight = 0. I changed the calculation to using the lineHeight of the font and multiplying it by the line count.Since the new height calculation needs the proper line count, I inversed the order of calling the methods in the
update()method. First the line count is set, then the alignment is calculated.I also added a test case with some different alignment settings:
TestBitmapFontAlignment.