Conversation
riccardobl
left a comment
There was a problem hiding this comment.
This PR is incomplete, as you can see the build fails with
/home/runner/work/jmonkeyengine/jmonkeyengine/jme3-android/src/main/java/com/jme3/system/android/JmeAndroidSystem.java:83: error: cannot find symbol
if (settings.getAudioRenderer().equals(AppSettings.ANDROID_MEDIAPLAYER)) {Also i've noticed you replaced some anonymous classes with lambdas, we can't do that atm, since we intend to maintain the support for old android versions and ios.
|
Dosen't look like anyone has commented issues with the PR; has it been long enough though to just go ahead and merge to master? |
|
There's a conflict in jme3-jogl/src/main/java/com/jme3/system/jogl/JoglContext.java that must be resolved before this PR can be integrated. @ItsMike54 please attempt to resolve the conflict. |
Thank you for commenting, I'll have a look at this issue. |
|
Out of date, reworking it as a new PR |
Fix for issue796 #796
JOGL support was simply removed due to its unpopularity and numerous bugs.