Skip to content

Update AppSettings.java#1310

Closed
ghost wants to merge 11 commits into
masterfrom
unknown repository
Closed

Update AppSettings.java#1310
ghost wants to merge 11 commits into
masterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Mar 26, 2020

Fix for issue796 #796
JOGL support was simply removed due to its unpopularity and numerous bugs.

Copy link
Copy Markdown
Member

@riccardobl riccardobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is incomplete, as you can see the build fails with

 /home/runner/work/jmonkeyengine/jmonkeyengine/jme3-android/src/main/java/com/jme3/system/android/JmeAndroidSystem.java:83: error: cannot find symbol

        if (settings.getAudioRenderer().equals(AppSettings.ANDROID_MEDIAPLAYER)) {

Also i've noticed you replaced some anonymous classes with lambdas, we can't do that atm, since we intend to maintain the support for old android versions and ios.

@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 3, 2020

Dosen't look like anyone has commented issues with the PR; has it been long enough though to just go ahead and merge to master?

@stephengold
Copy link
Copy Markdown
Member

There's a conflict in jme3-jogl/src/main/java/com/jme3/system/jogl/JoglContext.java that must be resolved before this PR can be integrated. @ItsMike54 please attempt to resolve the conflict.

@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 7, 2020

There's a conflict in jme3-jogl/src/main/java/com/jme3/system/jogl/JoglContext.java that must be resolved before this PR can be integrated. @ItsMike54 please attempt to resolve the conflict.

Thank you for commenting, I'll have a look at this issue.
EDIT: Is this a conflict in the code? jme3-jogl package was removed, and it still builds successfully.

@ghost ghost closed this Apr 7, 2020
@ghost ghost reopened this Apr 7, 2020
@ghost ghost closed this Apr 8, 2020
@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 8, 2020

Out of date, reworking it as a new PR

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants