Fixes #1304 - Don't use mat3() constructor to keep compatibility with…#1318
Merged
Conversation
…tibility with GLSL110
Member
Author
|
So now if fails with this: Edit: Sorry, nevermind, this is an old engine version... |
Member
Author
|
Sorry, the https://www.khronos.org/registry/OpenGL-Refpages/gl4/html/inverse.xhtml starts at GLSL140, which is 3.1 as well. Something for our GLSLCompat.glsllib? If so, I'll open an issue tomorrow. |
Member
Author
|
See #1321 |
Member
|
Included in v3.3 branch at 9dfbcde . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… GLSL110
Since I am not shader savy, please check all the relevant things for me (e.g. is L146 even needed? does the index refer to the individual column/row?).
I could however confirm that it does compile on my Compat Profile.