Set the minimum required OpenGL profiles for the geometry and tessellation shader test cases#1358
Conversation
…ation shader test cases. Resolves jMonkeyEngine#1357
|
I'll keep the PR open in case you want to add more commits. Let me know when you're done. |
|
I went through the rest of the examples, and did not encounter any other test scenerio's that required a higher core profile. You can close the PR. |
|
Thank you, @rvandoosselaer ! |
|
A couple caveats that just occurred to me:
|
|
I didn't consider your first remark. That is indeed correct. I haven't checked how the TestChooser is launching the examples. You will have different behaviour when launching. The second caveat is something I already bumped into a lot of times, given the strict behaviour of Macs. I did make sure to reset my preferences after running those 2 shader tests before testing other examples. |
|
Regarding #2, I propose giving every example that modifies |
|
My proposal doesn't work, so |
|
I’ll make it my ‘lockdown-project’ to systematically adapt all the test cases and force the default AppSettings. I’ll first need to check how the TestChooser works so the settings are also applied when launching an application from the TestChooser. Edit: if this is ok for the ‘owners’ of the repository. It will be a big PR and will absorb a large portion of my free time, so I want to make sure it’s ok upfront. |
|
I think you'll need to modify TestChooser. Other than that, I don't foresee any difficulties. |
See #1357