Calls the renderer's setMainFrameBufferSrgb method after a context restart#1524
Closed
Markil3 wants to merge 3 commits into
Closed
Calls the renderer's setMainFrameBufferSrgb method after a context restart#1524Markil3 wants to merge 3 commits into
Markil3 wants to merge 3 commits into
Conversation
…start This fixes a bug where gamma correction would be turned off after a context restart.
There is still that bug that we haven't solved, and I don't want it interfering with the demonstration of my gamma correction fix.
Contributor
Author
|
I was browsing the issues, and this should actually solve #844. |
Contributor
Author
|
In light of my discoveries in https://hub.jmonkeyengine.org/t/white-screen-on-context-restart-lwjgl-garbage-collection-issue/43866/28?u=markil3, I think we should hold off on this one. My new code would solve both this one and #1445, but the memory issue does make me hesitate a little to commit it immediately. |
Contributor
Author
|
Ultimately, #1526 is the more flexible way to pull this off, and I think we should go with that one instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in https://hub.jmonkeyengine.org/t/white-screen-on-context-restart/43866, this should fix a problem with gamma correction not being applied after a context restart.