Skip to content

Fixed the example TestMultiRenderTarget#1645

Closed
JohnLKkk wants to merge 1 commit into
jMonkeyEngine:masterfrom
JohnLKkk:master
Closed

Fixed the example TestMultiRenderTarget#1645
JohnLKkk wants to merge 1 commit into
jMonkeyEngine:masterfrom
JohnLKkk:master

Conversation

@JohnLKkk

@JohnLKkk JohnLKkk commented Nov 7, 2021

Copy link
Copy Markdown
Contributor

Uploading MRT.png…
This case originally seemed to be written by a retired predecessor to test delayed rendering, but its content is missing. I rewritten this case to help newbies use MRT technology outside of jme.

@stephengold

Copy link
Copy Markdown
Member

Thanks for your contribution to JMonkeyEngine.

@stephengold

stephengold commented Nov 10, 2021

Copy link
Copy Markdown
Member

Please add back the "Override" annotations you removed from the java source.

It's confusing to have 2 variables named "mrtLightingMaterial". Please rename one of them.

I don't understand what the comments at the end of reshape() are for. I realize you didn't add them. Are they still relevant?

The setDepthTexture() method is deprecated. Please use the new setDepthTarget() method instead.

@stephengold stephengold added this to the v3.5.0 milestone Nov 10, 2021
@stephengold stephengold added the examples specific to the jme3-examples sub-project label Nov 10, 2021
@JohnLKkk

Copy link
Copy Markdown
Contributor Author

Please add back the "Override" annotations you removed from the java source.

It's confusing to have 2 variables named "mrtLightingMaterial". Please rename one of them.

I don't understand what the comments at the end of reshape() are for. I realize you didn't add them. Are they still relevant?

The setDepthTexture() method is deprecated. Please use the new setDepthTarget() method instead.

Okay, I have been busy adjusting the RenderPipeline recently, and I only noticed your reply today. Feel sorry...

@JohnLKkk

Copy link
Copy Markdown
Contributor Author

The comments at the end of the reshape() method are some optimization techniques to help novices to implement MRT-based DeferredRender. To make the case as simple as possible, I have deleted these comments (these are actually the comments left by the previous predecessor)

@JohnLKkk

Copy link
Copy Markdown
Contributor Author

#1654

@stephengold

Copy link
Copy Markdown
Member

Why did you create PR #1654? I imagine it would be easier to push additional commits to this PR...

@JohnLKkk

Copy link
Copy Markdown
Contributor Author

This PR was modified directly on the master, and the other PR was modified on my own branch'kkk'.

@stephengold

Copy link
Copy Markdown
Member

Shall I close this one and review 1654?

@JohnLKkk

Copy link
Copy Markdown
Contributor Author

Yes, trouble you. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

examples specific to the jme3-examples sub-project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants