Skip to content

added a pre-order traversal of the scene graph. #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shamanDevel wants to merge 3 commits into from
Closed

added a pre-order traversal of the scene graph. #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9218dc4
added a pre-order traversal of the scene graph.
shamanTec Aug 21, 2014
4d6ed6c
fixed some missing change
shamanTec Aug 21, 2014
216eb30
changed depthLastTraversal to depthFirstTraversal with an extra flag
shamanTec Aug 21, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion jme3-blender/src/main/java/com/jme3/asset/BlenderKey.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -967,11 +967,12 @@ public Spatial deepClone() {
}

@Override
public void depthFirstTraversal(SceneGraphVisitor visitor) {
public void depthFirstTraversal(SceneGraphVisitor visitor, boolean preOrder) {
}

@Override
protected void breadthFirstTraversal(SceneGraphVisitor visitor, Queue<Spatial> queue) {
}

}
}
2 changes: 1 addition & 1 deletion jme3-core/src/main/java/com/jme3/scene/Geometry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ public int collideWith(Collidable other, CollisionResults results) {
}

@Override
public void depthFirstTraversal(SceneGraphVisitor visitor) {
public void depthFirstTraversal(SceneGraphVisitor visitor, boolean preOrder) {
visitor.visit(this);
}

Expand Down
18 changes: 13 additions & 5 deletions jme3-core/src/main/java/com/jme3/scene/Node.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,15 +625,23 @@ public void updateModelBound() {
}
}
}

@Override
public void depthFirstTraversal(SceneGraphVisitor visitor) {
for (Spatial child : children.getArray()) {
child.depthFirstTraversal(visitor);
public void depthFirstTraversal(SceneGraphVisitor visitor, boolean preOrder) {
if (preOrder) {
visitor.visit(this);
for (Spatial child : children.getArray()) {
child.depthFirstTraversal(visitor);
}
} else {
for (Spatial child : children.getArray()) {
child.depthFirstTraversal(visitor);
}
visitor.visit(this);
}
visitor.visit(this);
}


@Override
protected void breadthFirstTraversal(SceneGraphVisitor visitor, Queue<Spatial> queue) {
queue.addAll(children);
Expand Down
17 changes: 15 additions & 2 deletions jme3-core/src/main/java/com/jme3/scene/Spatial.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1492,10 +1492,23 @@ public Matrix4f getLocalToWorldMatrix(Matrix4f store) {
}

/**
* Visit each scene graph element ordered by DFS
* Visit each scene graph element ordered by DFS, also called post order traversal.
* Delegates to {@link #depthFirstTraversal(com.jme3.scene.SceneGraphVisitor, boolean) }
* with {@code preOrder} set to {@code false}.
* @param visitor
*/
public abstract void depthFirstTraversal(SceneGraphVisitor visitor);
public void depthFirstTraversal(SceneGraphVisitor visitor) {
depthFirstTraversal(visitor, false);
Copy link
Copy Markdown

@Shredder121 Shredder121 Jul 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didnt see this one, my comment can be ignored.

}

/**
* Visit each scene graph element using post order traversal if {@code preOrder}
* is {@code false} or using pre order traversal if {@code preOrder} is
* {@code true}.
* @param visitor the visitor to use
* @param preOrder {@code false} for post order, {@code true} for pre order
*/
public abstract void depthFirstTraversal(SceneGraphVisitor visitor, boolean preOrder);

/**
* Visit each scene graph element ordered by BFS
Expand Down