Increase MAX_DEFINES in DefineList (re-do)#2116
Merged
Merged
Conversation
Member
|
I took a look through and everything looks identical to my changes to DefineList and TehcniqueDef in my other bugged PR, so this PR looks like its all good now! Unless anyone else has anything to add/suggest then I say its ready to be integrated. |
yaRnMcDonuts
approved these changes
Oct 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-implements the changes @yaRnMcDonuts made to
DefineListandTechniquein #2033.It implements new fixes to
OpaqueComparatorTestandDefineListTestthat better reflect the intent of those tests.It also updates copyright dates and improves the formatting of affected code.