Conversation
|
@gemini-code-assist do a new review |
|
🖼️ Screenshot tests have failed. The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests. 📄 Where to find the report:
✅ If you did mean to change things: ✨ If you are creating entirely new tests: Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar". See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information Contact @richardTingle (aka richtea) for guidance if required |
There was a problem hiding this comment.
Code Review
This pull request introduces StbImageLoader as a unified, cross-platform image loader using the stb-image library, leading to the deprecation of AWTLoader, HDRLoader, and TGALoader. It also adds support for R16F and RG16F formats in ImageCodec. Review feedback highlights a potential thread-safety issue with the shared StbImage instance, suggests marking 8-bit luminance formats as sRGB for consistency with previous loaders, and notes a minor formatting correction.
…ader.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This PR replaces (and deprecates) AWTLoader, HDRLoader, TGALoader and the android native loader (except for webp, heic, heif), with a multiplatform java port of stb-image.
Based on : #2721