build only on java 25 and download it if needed#2735
Merged
riccardobl merged 1 commit intojMonkeyEngine:masterfrom May 1, 2026
Merged
build only on java 25 and download it if needed#2735riccardobl merged 1 commit intojMonkeyEngine:masterfrom
riccardobl merged 1 commit intojMonkeyEngine:masterfrom
Conversation
Co-authored-by: Copilot <copilot@github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements Gradle toolchains for the project, setting the Java language version to 25 and configuring the Foojay resolver plugin. Feedback identifies critical issues with the configuration: the Foojay plugin version 1.0.0 is non-existent and should be 0.9.0, and the Java language version 25 is not yet released and should likely be 21.
| * This is the global settings file used by all subprojects. | ||
| **/ | ||
| plugins { | ||
| id 'org.gradle.toolchains.foojay-resolver-convention' version '1.0.0' |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| sourceCompatibility = JavaVersion.VERSION_1_8 | ||
| targetCompatibility = JavaVersion.VERSION_1_8 | ||
| toolchain { | ||
| languageVersion = JavaLanguageVersion.of(25) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
options.release = 8should guarantee that we use java 8 standard lib.With this in place it should be fine to compile only with java 25 in CI, making the build faster.
This PR also makes sure java 25 is automatically downloaded with foojay toolchains.