Skip to content

Workaround vscode issue with jme3-examples#2781

Merged
riccardobl merged 1 commit into
jMonkeyEngine:masterfrom
riccardobl:testdatafix
May 17, 2026
Merged

Workaround vscode issue with jme3-examples#2781
riccardobl merged 1 commit into
jMonkeyEngine:masterfrom
riccardobl:testdatafix

Conversation

@riccardobl
Copy link
Copy Markdown
Member

@riccardobl riccardobl commented May 17, 2026

vscode java test runner does not like that jme3-examples has a runtimeOnly dependency to testdata and reports build errors.

This PR switches it to implementation. This change should not matter for us, since this module contains only examples anyway.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the build.gradle file for the jme3-examples project, changing the dependency on :jme3-testdata from runtimeOnly to implementation. I have no feedback to provide as there are no review comments.

@riccardobl riccardobl merged commit 6dc668b into jMonkeyEngine:master May 17, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant