Enable Javadoc doclint errors#2799
Conversation
|
🖼️ Screenshot tests have failed. The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests. 📄 Where to find the report:
✅ If you did mean to change things: ✨ If you are creating entirely new tests: Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar". See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information Contact @richardTingle (aka richtea) for guidance if required |
There was a problem hiding this comment.
Code Review
This pull request focuses on improving Javadoc quality and consistency across the project. Key changes include fixing malformed HTML tags, updating parameter descriptions to match method signatures, and removing Javadoc error suppression in Gradle build files to enforce stricter documentation standards. A review comment identifies a grammatical improvement in BlendSpace.java, suggesting the use of "between" instead of "among" when referring to exactly two actions.
b6f51ca to
d1e7c04
Compare
|
Rebased + now ready for review |
d1e7c04 to
89a9dab
Compare
|
This one should be good @riccardobl but I believe there's an issue with the build recently with your ios changes |
|
Thanks! |
|
Reverted this for now, because it was causing the build to fail due to javadoc errors https://github.com/jMonkeyEngine/jmonkeyengine/actions/runs/26560877797/job/78243326387 Feel free to open a new pr for this. |
Summary