Support exclusive fullscreen#2814
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for configuring different fullscreen modes (borderless window and exclusive fullscreen) in the application settings and implements the corresponding backend logic using SDL in the LWJGL3 window system. Specifically, it adds FULLSCREEN_MODE_BORDERLESS_WINDOW and FULLSCREEN_MODE_EXCLUSIVE_FULLSCREEN constants, getters, and setters to AppSettings, and updates LwjglWindow to resolve display origins and apply the requested fullscreen mode via native SDL calls. There are no review comments to address, and I have no further feedback to provide.
8Keep
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds exclusive fullscreen to the SDL3 backend, and a
FullscreenModeAppSetting to toggle between borderless window and exclusive fullscreen