Skip to content

Default EnvironmentProbe SH baking to FAST and remove AUTO mode#2817

Merged
riccardobl merged 6 commits into
masterfrom
copilot/fix-quality-env-baker-macos
May 28, 2026
Merged

Default EnvironmentProbe SH baking to FAST and remove AUTO mode#2817
riccardobl merged 6 commits into
masterfrom
copilot/fix-quality-env-baker-macos

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 26, 2026

QUALITY SH baking is unstable on macOS when using ANGLE/Metal, and AUTO could still route into problematic behavior depending on platform logic. This update removes AUTO entirely and makes FAST the default SH baking path.

  • Mode model simplification (AUTO removed)

    • Removed SphericalHarmonicsMode.AUTO from IBLGLEnvBakerLight.
    • Removed OS-based AUTO branching in SH bake path.
    • Kept explicit FAST and QUALITY behavior unchanged.
  • Default behavior change to FAST

    • Updated IBLGLEnvBakerLight default SH mode to FAST.
    • Updated EnvironmentProbeControl default SH mode to FAST.
    • Updated serialized default in EnvironmentProbeControl.write(...) to FAST.
  • Backward compatibility for serialized data

    • Added compatibility mapping in EnvironmentProbeControl.read(...) so legacy serialized mode values (including "AUTO") resolve to FAST instead of failing or requiring AUTO to exist.
public enum SphericalHarmonicsMode {
    FAST,
    QUALITY
}

[!WARNING]

Copilot AI changed the title [WIP] Fix QUALITY env baker support on macOS with ANGLE Default EnvironmentProbe SH baking to FAST and remove AUTO mode May 26, 2026
Copilot AI requested a review from riccardobl May 26, 2026 17:24
@@ -0,0 +1,72 @@
/*
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot remove this test, it is useless

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in commit 9c403a9: removed jme3-core/src/test/java/com/jme3/environment/EnvironmentProbeControlTest.java.

@riccardobl riccardobl marked this pull request as ready for review May 27, 2026 09:16
Copilot AI requested a review from riccardobl May 27, 2026 09:20
@riccardobl riccardobl merged commit 032a493 into master May 28, 2026
1 check passed
@riccardobl riccardobl deleted the copilot/fix-quality-env-baker-macos branch May 28, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QUALITY env baker is not well supported by angle on macos

2 participants