Default shader version selection to GLSL300 for GLES3#2819
Merged
riccardobl merged 2 commits intoMay 28, 2026
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the GLSL shader versioning logic in GLRenderer.java to support GLES3, upgrading versions between 150 and 300 to 300, and forcing #version 300 es for older shaders under GLES3. However, forcing GLSL 100 shaders to compile under #version 300 es will cause compilation failures due to deprecated keywords like attribute and varying which are unsupported in GLSL ES 3.00. Additionally, using String.valueOf(version) inside StringBuilder.append() is redundant and should be simplified to avoid unnecessary string allocations.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JME shader version default ( GLSL100 ) selects the minimum glsl version available in the platform.
The problem is that in GLES3 it defaults to
GLSL100(GLES2) for every shader that is not specifically hinted toGLSL300, this means thatGLSL>=150 && GLSL < 300shaders that would otherwise run fine in GLES3 are downgraded to GLES2 and break.GLES2 is not supported anymore and, after the recent updates to the engine, GLES3.0 is guaranteed in every platform, so having to deal with GLES2 and all its quirkiness just to support a lower default is not worth.
This PR move the default to
GLSL300when using a GLES backend.If a shader is written with the old syntax, after this PR it needs to import
GLSLCompat.glsllib, but this technically already the case in jme, since withoutGLSLCompatthe shader will not work properly anyway.