Don't force non-srgb capable framebuffer in desktop backend#2824
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors OpenGL driver hints and window creation logic in LwjglWindow.java. It replaces configureAngleHints with configureOpenGLDriverHints, forces EGL on Linux when ANGLE is not used, and simplifies window creation by removing sRGB framebuffer fallback logic. A review comment suggests respecting the isX11PlatformPreferred() setting on Linux before forcing EGL to avoid breaking compatibility on older X11 systems.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
riccardobl
changed the title
Member
|
I verified this fix by using commit 4f26497 to run |
# Conflicts: # jme3-lwjgl3/src/main/java/com/jme3/system/lwjgl/LwjglWindow.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported here: #2823
When using OpenGL (instead of the default ANGLE_GLES) in the new desktop renderer backend, the window creation can fail.
This surfaced two issues:
The OpenGL path uses GLX instead of EGLThis PR fixes both.
(edit: EGL is not forced on X11, since gemini says some X11 platforms might not be compatible)
closes #2823