Include ios and android example modules only when their tasks are executed#2825
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies settings.gradle to conditionally include the jme3-ios-examples project only when building on macOS. The feedback suggests simplifying the OS detection logic by removing the redundant default value for the os.name system property, as it is guaranteed to be populated by any standard JVM.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
riccardobl
changed the title
|
/gemini review |
riccardobl
changed the title
There was a problem hiding this comment.
Code Review
This pull request introduces tasks to run Android and iOS examples and conditionally includes the respective subprojects (jme3-android-examples and jme3-ios-examples) in settings.gradle only when their execution is requested. The reviewer noted that the checks for requested tasks do not account for subproject task paths specified without a leading colon (e.g., jme3-android-examples:assembleDebug or jme3-ios-examples:runIosExamples), which could cause build failures, and provided code suggestions to resolve this.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 participant
hopefully fix some ci instability