fix nifty to support non rgba images in non-gles backends#2842
fix nifty to support non rgba images in non-gles backends#2842riccardobl wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the GLES-specific platform check in JmeBatchRenderBackend.loadImage, causing the RGBA8 conversion logic to run unconditionally on all platforms when the texture format is not Format.RGBA8. The reviewer correctly identified that this can lead to runtime crashes (UnsupportedOperationException) when loading compressed textures (like DXT or ETC) because ImageRaster does not support them, and suggested adding a check using ImageRaster.isSupported to prevent this issue.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…ckend.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
🖼️ Screenshot tests have failed. The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests. 📄 Where to find the report:
✅ If you did mean to change things: ✨ If you are creating entirely new tests: Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar". See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information Contact @richardTingle (aka richtea) for guidance if required |
No description provided.