Reversed raytest results when needed#471
Conversation
In some cases, native-bullet returns the ray results on a reversed order so it leads to unexpected bugs.
|
Is this a fix of the perceived Result, or was the actual bullet code looked at to determine if only those two orders can appear? After this commit, we kind of guarantee that the result is always correctly ordered, so we should make sure, that is actually is. (As this could be a cause for quite subtle bugs for many users) |
|
Is a fix of the perceived Result. I tried to look at the bullet code but I'm not skilled enough at the moment (and neither have time to get that skill) to ensure is working like that. However, I made a few tests (simple, can't ensure at 100%). However, I'm using it in my game and works fine 👍 |
|
I would recommend to just do a sort. We don't know what the intended order is in this case so better not make any assumptions. |
|
Talking about assumptions, isn't there a way to know which is the intended order by asking bullet people? (I don't know how feasible is this) |
|
@NemesisMate |
|
Ok, rejected merging this, as no guarantee of the outcome is made I would feel very happy, if you would resubmit with that smaller change in behaviour. |
In some cases, native-bullet returns the ray results on a reversed order so it leads to unexpected bugs.
More details can be found here.