Use MPOs for skinning#717
Merged
Merged
Conversation
Nehon
approved these changes
Sep 8, 2017
Contributor
Nehon
left a comment
Nehon
left a comment
There was a problem hiding this comment.
Nice, this was pretty annoying.
I just have one comment.
|
|
||
| // get boneIndexes and weights for mesh | ||
| indexReader.setBuffer(mesh.getBuffer(Type.BoneIndex).getData()); | ||
| IndexBuffer ib = IndexBuffer.wrapIndexBuffer(mesh.getBuffer(Type.BoneIndex).getData()); |
Contributor
There was a problem hiding this comment.
Won't that create a new instance of the wrapper on each frame ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the annoying "Material instances cannot be shared when hardware skinning is used" error