Fixed file lock leaks in GLSLLoader.#738
Merged
shadowislord merged 1 commit intoSep 21, 2017
Merged
Conversation
Contributor
Author
|
@Nehon I don't use Windows OS, but this problem came from some users of my editor, in the case with game application it isn't the important problem, but I think we need to fix it :) |
JavaSaBr
changed the title
Nehon
approved these changes
Sep 19, 2017
Contributor
Nehon
left a comment
Nehon
left a comment
There was a problem hiding this comment.
Yes. I agree on this one. Also the try with ressource is more elegant.
MeFisto94
pushed a commit
to MeFisto94/jmonkeyengine
that referenced
this pull request
Dec 1, 2017
MeFisto94
pushed a commit
to MeFisto94/jmonkeyengine
that referenced
this pull request
Dec 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We didn't close readers of shader streams in the GLSLLoader. It provided some file lock leaks and then I couldn't change these files on windows without restarting jME application.