making VRViewManagerOSVR more similar to VRViewManagerOpenVR#756
Merged
Conversation
MeFisto94
pushed a commit
to MeFisto94/jmonkeyengine
that referenced
this pull request
Dec 1, 2017
making VRViewManagerOSVR more similar to VRViewManagerOpenVR
MeFisto94
pushed a commit
to MeFisto94/jmonkeyengine
that referenced
this pull request
Dec 1, 2017
making VRViewManagerOSVR more similar to VRViewManagerOpenVR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparing the classes VRViewManagerOpenVR and VRViewManagerOSVR there are some obvious refactoring possibiliets in VRViewManagerOSVR, like overridden fields and methods. This could possibly (although not likely) fix the issue described in https://hub.jmonkeyengine.org/t/official-vr-module/37830/47